Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Fix Playglobalsound Autocompletion #319

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26167: Fix playglobalsound autocompletion from space-wizards space-wizards/space-station-14

65960facf522627c939a35a65b025ec49ffa5c52

PR opened by metalgearsloth at 2024-03-16 03:02:08 UTC


PR changed 1 files with 3 additions and 1 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

Requires space-wizards/RobustToolbox#4968

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
Copy link
Contributor

@DangerRevolution DangerRevolution left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what this does

@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
@VMSolidus VMSolidus marked this pull request as ready for review May 12, 2024 03:54
@VMSolidus
Copy link
Member

not sure what this does

It makes it so that when an admin is playing a sound, the autocomplete system only completes to actual sound files and not random garbage.

@github-actions github-actions bot added the Changes: C# Changes any cs files label Jun 18, 2024
@SimpleStation14 SimpleStation14 changed the title Mirror: Fix playglobalsound autocompletion Mirror: Fix Playglobalsound Autocompletion Jun 18, 2024
@DEATHB4DEFEAT DEATHB4DEFEAT merged commit 6949685 into Simple-Station:master Jul 12, 2024
5 of 11 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants