Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Fix SCRAM implant not working while cuffed. Incidentally fix freedom implant working while dead/crit #266

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #25978: Fix SCRAM implant not working while cuffed. Incidentally fix freedom implant working while dead/crit from space-wizards space-wizards/space-station-14

22e9d6562f21bdd4f0962d6e3b6fcdd81bb4c253

PR opened by nikthechampiongr at 2024-03-10 19:33:05 UTC


PR changed 13 files with 142 additions and 3 deletions.

The PR had the following labels:

  • Status: Needs Review

Original Body

fixes #25662

About the PR

This pr makes it so you can use the SCRAM implant while cuffed. Also fixes the freedom implant working while you are in crit, or even dead.

Why / Balance

The implant is made so you can escape horrible situations. It should as such work while in crit.

Technical details

ActionBlockers now has a specific check to see if someone is conscious. It is also used in the Interaction check now. Actions can now use that check if the bool is set. The bool is now set for the freedom and SCRAM! implant actions. Additionally the SCRAM! action now ignores whether the user can interact in order to be able to use it while cuffed.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑
fix: You can now use the SCRAM! implant while cuffed.
fix: The freedom implant can no longer be used while in crit, or dead.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:12
@VMSolidus VMSolidus marked this pull request as ready for review May 12, 2024 04:13
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh shit that's cool, it also adds a special case for actions that can be done while you're conscious, but don't require your hands. Such as purely mental actions. That'll be INCREDIBLY useful for almost all psychic powers.

@VMSolidus VMSolidus merged commit 151b5e1 into Simple-Station:master May 12, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants