Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Prevent dead players from turning bar stools #213

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #24308: Prevent dead players from turning bar stools from space-wizards space-wizards/space-station-14

15a7520df17a6fa95cbd8ce8914edab5b0d7ed50

PR opened by Nopey at 2024-01-19 22:47:45 UTC


PR changed 3 files with 11 additions and 18 deletions.

The PR had the following labels:


Original Body

About the PR

Bugfix.

Why / Balance

Previously, players could always turn a bar stool (or office chair, etc..) they were buckled into; even while stone cold dead.

Technical details

RotateToFaceSystem now only lets players rotate barstools (& similar) when the actionBlockerSystem reports that they CanChangeDirection; this also means players who are frozen by admins (see AdminFrozenSystem) can no longer spin barstools.

SharedBuckleSystem no longer tries to prevent buckled players from being able to change direction, instead relying on RotateToFaceSystem to ensure that players on beds and such don't rotate.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame

Video showcasing prior broken behavior:

2024-01-19.17-44-44.mp4

Breaking changes

Changelog
🆑

  • fix: Dead players can no longer spin on a bar stool.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 6, 2024 19:11
@VMSolidus VMSolidus merged commit 04c45bb into Simple-Station:master May 9, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants