Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror: Throttle people trying to connect to a full server. #197

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #20972: Throttle people trying to connect to a full server. from space-wizards space-wizards/space-station-14

0ecc5e8c96c235af265ab747d7345b363f94b1e4

PR opened by PJB3005 at 2023-10-13 19:33:57 UTC


PR changed 5 files with 86 additions and 26 deletions.

The PR had the following labels:

  • Changes: UI

Original Body

To reduce spam/load on the server and connection logs table.

Players are forced to wait 30 seconds after getting denied for "server full", before they can try connecting again.

This code is an absolute nightmare mess. I tried to re-use the existing code for the redial timer but god everything here sucks so much.

Requires space-wizards/RobustToolbox#4487

Changelog

🆑

  • tweak: You must now wait 30 seconds before attempting to reconnect to a full server.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label Apr 22, 2024
@SimpleStation14 SimpleStation14 marked this pull request as draft May 4, 2024 21:13
@VMSolidus VMSolidus marked this pull request as ready for review May 9, 2024 05:37
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label May 13, 2024
@FoxxoTrystan
Copy link
Contributor

This PR is needed now with the Queue? or that is for the hard limit?
Well merge conflict time, sadly i cannot look at it.

@VMSolidus
Copy link
Member

Yea this isn't really necessary anymore with a queue system.

@VMSolidus VMSolidus closed this May 13, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot Status: Merge Conflict FIX YOUR PR AAAGH
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants