Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Den Mass Cherry-Pick 01/06/25 #1443

Conversation

angelofallars
Copy link
Contributor

@angelofallars angelofallars commented Jan 5, 2025

Description

(Use a MERGE COMMIT, not squash if possible to avoid reduce merge conflicts for our downstream)

Cherry-picks some PRs from The Den:

Changelog

🆑 The Den Contributors

  • fix: Put actual prescription lenses in the prescription medhuds and sechuds (by KyuPolaris)
  • add: Added the CMO turtleneck and head mirror to the CMO loadouts. (by sleepyyapril, KyuPolaris)
  • add: Added an armored trenchcoat for the Captain. Enjoy your swag! (by Rosycup)
  • fix: Fixed uneven pants leg on summer security uniforms. (by Rosycup)
  • add: Added the Captain's Combat Gas Mask, for those more fond of close encounters. (by Rosycup)
  • tweak: Added the Captain's Trenchcoat to the other captain locker variants. (by Rosycup)
  • fix: Fixed they/them pronouns being displayed for it/its characters in the character preview. (by Azzy)

@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an RSI labels Jan 5, 2025
@angelofallars angelofallars changed the title The Den Selective Merge 01/06/25 The Den Mass Cherry-Pick 01/06/25 Jan 5, 2025
Copy link
Contributor

github-actions bot commented Jan 5, 2025

RSI Diff Bot; head commit 3922f11 merging into e31692d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Nyanotrasen/Clothing/Uniforms/Jumpsuit/summer_security.rsi

State Old New Status
equipped-INNERCLOTHING Modified

Resources/Textures/Clothing/Head/Misc/head_mirror.rsi

State Old New Status
equipped-HELMET Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Clothing/Mask/gascaptaincombat.rsi

State Old New Status
equipped-MASK-reptilian Added
equipped-MASK-vox Added
equipped-MASK-vulpkanin Added
equipped-MASK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Clothing/OuterClothing/Coats/cap_trenchcoat.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Clothing/Uniforms/Jumpskirt/cmo_turtle.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Clothing/Uniforms/Jumpsuit/cmo_turtle.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 3922f11

sleepyyapril and others added 9 commits January 6, 2025 04:06
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Added a fashionable Captain's Armored Trenchcoat.

---

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl: Rosycup
- add: Added an armored trenchcoat for the Captain. Enjoy your swag!
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Fixed sec's summer uniform sprite having uneven pants.

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- fix: Fixed uneven pants leg on summer security uniforms.
Fixes the pronouns in the character preview to not show they/them
pronouns for characters that use it/its

<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

This just adds another condition in the fluent file that controls the
character preview text.

Essentially, characters that use it/its pronouns will go from:

"This is [character]. They are X years old."

to

"This is [character]. It is X years old."

---

# TODO

<!--
A list of everything you have to do before this PR is "complete"
You probably won't have to complete everything before merging but it's
good to leave future references
-->

- [x] Probably test it, maybe.

---

<!--
This is default collapsed, readers click to expand it and see all your
media
The PR media section can get very large at times, so this is a good way
to keep it clean
The title is written using HTML tags
The title must be within the <summary> tags or you won't see it
-->

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl: Azzy
- fix: Fixed they/them pronouns being displayed for it/its characters in
the character preview.
# Description

Re-adds CMO Turtleneck to the loadout (I swear to fucking god if I have
to re-add it again I am going to commit many war crimes)

---

# TODO

- [x] turtle neck 👍

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- add: CMO Turtleneck back to loadout
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Adds a gas mask variant for the captain intended for combat encounters.

---

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- add: Added the Captain's Combat Gas Mask, for those more fond of close
encounters.
- tweak: Added the Captain's Trenchcoat to the other captain locker
variants.
@angelofallars angelofallars force-pushed the the-den-downstream-merge-01-06-25 branch from 38d7913 to 3922f11 Compare January 5, 2025 20:06
@sleepyyapril
Copy link
Contributor

im going to hate you when i upstream merge if you change namespaces.

@angelofallars
Copy link
Contributor Author

im going to hate you when i upstream merge if you change namespaces.

oops :trollface:

@VMSolidus VMSolidus merged commit ca0b40a into Simple-Station:master Jan 5, 2025
12 of 13 checks passed
SimpleStation14 added a commit that referenced this pull request Jan 5, 2025
@VMSolidus
Copy link
Member

FUCK I SQUASHED IT WITHOUT REALIZING WHAT I WAS DOING. GODDAMNIT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants