Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ports Shitmed Updates From Goob #1387

Merged
merged 8 commits into from
Dec 31, 2024
Merged

Ports Shitmed Updates From Goob #1387

merged 8 commits into from
Dec 31, 2024

Conversation

gluesniffler
Copy link
Contributor

@gluesniffler gluesniffler commented Dec 31, 2024 •
edited
Loading

Lots of stuff. Also moved everything I could to the _Shitmed namespace as I do in Goob. Will make future ports way faster

Changelog

🆑 Mocho

  • add: Added some fun organs and other thingies, check out the Goob PRs if you want more details.
  • fix: Fixed tons of issues with shitmed. Too many for the changelog in fact.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: UI Changes any XAML files Changes: Documentation Changes any xml or md files Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an RSI Changes: Audio Changes any ogg files labels Dec 31, 2024
@SimpleStation14 SimpleStation14 changed the title Ports Shitmed Updates from Goob Ports Shitmed Updates From Goob Dec 31, 2024
VMSolidus
VMSolidus previously approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, I was excitedly waiting for this port to be finished. Good thing this makes keeping parity and updates easier.

@VMSolidus VMSolidus dismissed their stale review December 31, 2024 18:57

Actually I should wait for the linters to pass first lol

@sleepyyapril
Copy link
Contributor

bro got the chairs failing!!

@gluesniffler
Copy link
Contributor Author

bro got the chairs failing!!

epic n14 port fail

@github-actions github-actions bot added the Status: Needs Review Someone please review this label Dec 31, 2024
VMSolidus
VMSolidus approved these changes Dec 31, 2024
View reviewed changes
Copy link
Member

@VMSolidus VMSolidus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how the stupid map assets accidentally added a new heisentest. We're back up to 2 heisentests again.

@sleepyyapril sleepyyapril merged commit 3c9db94 into Simple-Station:master Dec 31, 2024
11 of 12 checks passed
sleepyyapril pushed a commit to VMSolidus/Einstein-Engines that referenced this pull request Dec 31, 2024
@SimpleStation14
Automatic Changelog Update (Simple-Station#1387)
280aa4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleepyyapril sleepyyapril sleepyyapril approved these changes

@VMSolidus VMSolidus VMSolidus approved these changes

Assignees
No one assigned
Labels
Changes: Audio Changes any ogg files Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: UI Changes any XAML files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gluesniffler @sleepyyapril @VMSolidus