Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Multiclassing Trait - Restricted Gear #1317

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

WarMechanic
Copy link
Contributor

@WarMechanic WarMechanic commented Dec 6, 2024

Description

Adds a new trait 'Restricted Gear' that unlocks job requirements for a curated list of items (most equipment), allowing you to take items from other jobs at a loadout and trait cost.

The main idea is to allow freedom of choosing items 'initial player power' at a cost of trait points 'final player power', as well as effectively automating greytiding. Item selection is moderated through loadout cost, all the numbers are up for discretion.

This trait is definitely not suitable for all servers, but it has a place in lowpop RP downstreams like Grimbly Station which I play on.


TODO

This PR only really features yml changes, so it could be considered in a complete state. However there is also room for design / balance discussion.

  • Should command staff be able to use Restricted Gear? (currently yes)
  • Should prisoners be able to use Restricted Gear? (currently no, but funny)
    • it would also be possible to add item restrictions on restricted gear so prisoners cant smuggle guns
  • Should Restricted Gear grant access to certain items on your current job? (Heirloom armory weapons for security, lethal .50 for bartender etc)
  • Tweaking of numbers, interpolation between trait cost and loadout cost.
  • Does this trait need a CVar requirement? (there was some discussion on discord about it)
  • Probably more that I haven't stated.

Of course, this can also be tailored to any downstream as required.


Media

Trait name / description:
image
(dw death i changed it's to its)

You can use exchange loadout points to get other jobs' items.
image

Loadout point costs don't apply to your own job.
image


Changelog

🆑

  • add: Added a trait 'Restricted Gear' which unlocks loadout job restrictions.

@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Dec 6, 2024
@WarMechanic WarMechanic marked this pull request as ready for review December 6, 2024 07:45
@sleepyyapril
Copy link
Contributor

  • Should command staff be able to use Restricted Gear? (currently yes)
  • Should prisoners be able to use Restricted Gear? (currently no, but funny)
    • it would also be possible to add item restrictions on restricted gear so prisoners cant smuggle guns
  • Should Restricted Gear grant access to certain items on your current job? (Heirloom armory weapons for security, lethal .50 for bartender etc)
  • Tweaking of numbers, interpolation between trait cost and loadout cost.
  • Does this trait need a CVar requirement? (there was some discussion on discord about it)
  • I'm tempted to add 'heirloom' to literally everything, however this would conflict with my "You cannot smuggle from your own job" approach.
  • Probably more that I haven't stated.

Most of this should be set in a state of "the least game-changing settings" and let others change it.
So, for example a CVar requirement, which I recommend waiting for.

@WarMechanic
Copy link
Contributor Author

WarMechanic commented Dec 6, 2024

Most of this should be set in a state of "the least game-changing settings" and let others change it.

i think the current iteration should be somewhat 'okay' in terms of numbers, a lot of the sus stuff is quite expensive and guns especially itll be hard to get ammo for unless you roll traitor since you otherwise get only 1 gun + 1 spare mag.

@WarMechanic
Copy link
Contributor Author

is the ubuntu fail real

@sleepyyapril
Copy link
Contributor

is the ubuntu fail real

No

@sleepyyapril sleepyyapril added Status: Needs Discussion Must be discussed Size: 4-Small For small issues/PRs labels Dec 6, 2024
@github-actions github-actions bot added Status: Needs Review Someone please review this labels Dec 6, 2024
@sleepyyapril sleepyyapril added the Priority: 4-Low Should be resolved at some point label Dec 6, 2024
@WarMechanic WarMechanic marked this pull request as draft December 7, 2024 07:04
@github-actions github-actions bot added the Changes: C# Changes any cs files label Dec 8, 2024
@VMSolidus VMSolidus marked this pull request as ready for review December 13, 2024 17:44
@VMSolidus
Copy link
Member

Tests were failing because you included the word (r)equires in your PR description

@WarMechanic
Copy link
Contributor Author

i drafted the pr because cvars werent working locally and i didn't want to submit something that didnt work
(in hindsight i probably should have written this on the pr)
but if working cvars arent a requirement then the actually trait side of things is all functional, theres also the small chance its simply not working on my computer

i think itd be wise to test merge it on deep or something

@sleepyyapril
Copy link
Contributor

i drafted the pr because cvars werent working locally and i didn't want to submit something that didnt work (in hindsight i probably should have written this on the pr) but if working cvars arent a requirement then the actually trait side of things is all functional, theres also the small chance its simply not working on my computer

i think itd be wise to test merge it on deep or something

again, i tested the cvar requirement locally and it was fine. ill merge the fix to your PR in a minute when I get the YML linter to stop yelling at me on the wizmerge.

@WarMechanic
Copy link
Contributor Author

damn something mustve been wrong on my end

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Dec 16, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Status: Merge Conflict FIX YOUR PR AAAGH label Dec 17, 2024
@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Dec 26, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Priority: 4-Low Should be resolved at some point Size: 4-Small For small issues/PRs Status: Merge Conflict FIX YOUR PR AAAGH Status: Needs Discussion Must be discussed Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants