Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Mechs (Wizden PR #32346) #1018

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

VMSolidus
Copy link
Member

@VMSolidus VMSolidus commented Oct 7, 2024

Description

This is a port of space-wizards/space-station-14#32346
Which was abandoned by its original creator. I am continuing the PR here.

TODO

  • Code Cleanup
  • Testing

Media

Example Media Embed

Changelog

🆑

  • tweak: H.O.N.K. received an airtight cabin for honk operations.
  • add: Added new NT mech - Ripley MK-II (Has a pressurized cabin for space operations, but the added weight has slowed it down.)
  • add: Added new NT mech - Clarke (A fast-moving mech for space travel. It has built-in trusts.)
  • add: Added new NT mech - Gygax (While lightly armored, the Gygax has incredible mobility thanks to its ability that lets it smash through walls at high speeds.)
  • add: Added new NT mech - Durand (A slow but beefy combat exosuit that is extra scary in confined spaces due to its punches.)
  • add: Added new CentCom mech - Marauder (A specialized mech issued to the ERT.)
  • add: Added new DeathSquad mech - Seraph (A limited edition exosuit that comes with advanced equipment.)
  • add: Cybersan began producing combat mechs to supply nuclear operatives with them. (Drak Gygax - 100 TC and Mauler - 150 TC)
  • add: In the exosuit fabricator, you can now create researched mechs such as: Ripley MK-2, Clark, Gygax, Durand.

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: YML Changes any yml files labels Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

RSI Diff Bot; head commit 12a53c1 merging into 8ba95f3
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Specific/Mech/ripley_construction.rsi

State Old New Status
ripley_chassis Modified
ripley_harness+o Modified
ripley_harness Modified

Resources/Textures/Objects/Specific/Mech/clarke_construction.rsi

State Old New Status
clarke0 Added
clarke1 Added
clarke10 Added
clarke11 Added
clarke12 Added
clarke13 Added
clarke14 Added
clarke15 Added
clarke16 Added
clarke2 Added
clarke3 Added
clarke4 Added
clarke5 Added
clarke6 Added
clarke7 Added
clarke8 Added
clarke9 Added
clarke_chassis Added
clarke_harness+o Added
clarke_harness Added
clarke_head+o Added
clarke_head Added
clarke_l_arm+o Added
clarke_l_arm Added
clarke_r_arm+o Added
clarke_r_arm Added
clarke_treads+o Added
clarke_treads Added

Resources/Textures/Objects/Specific/Mech/durand_construction.rsi

State Old New Status
durand0 Added
durand1 Added
durand10 Added
durand11 Added
durand12 Added
durand13 Added
durand14 Added
durand15 Added
durand16 Added
durand17 Added
durand18 Added
durand2 Added
durand3 Added
durand4 Added
durand5 Added
durand6 Added
durand7 Added
durand8 Added
durand9 Added
durand_armor Added
durand_chassis Added
durand_harness+o Added
durand_harness Added
durand_head+o Added
durand_head Added
durand_l_arm+o Added
durand_l_arm Added
durand_l_leg+o Added
durand_l_leg Added
durand_r_arm+o Added
durand_r_arm Added
durand_r_leg+o Added
durand_r_leg Added

Resources/Textures/Objects/Specific/Mech/gygax_construction.rsi

State Old New Status
gygax0 Added
gygax1 Added
gygax10 Added
gygax11 Added
gygax12 Added
gygax13 Added
gygax14 Added
gygax15 Added
gygax16 Added
gygax17 Added
gygax18 Added
gygax19 Added
gygax2 Added
gygax20 Added
gygax3 Added
gygax4 Added
gygax5 Added
gygax6 Added
gygax7 Added
gygax8 Added
gygax9 Added
gygax_armor Added
gygax_chassis Added
gygax_harness+o Added
gygax_harness Added
gygax_head+o Added
gygax_head Added
gygax_l_arm+o Added
gygax_l_arm Added
gygax_l_leg+o Added
gygax_l_leg Added
gygax_r_arm+o Added
gygax_r_arm Added
gygax_r_leg+o Added
gygax_r_leg Added

Resources/Textures/Objects/Specific/Mech/mecha_equipment.rsi

State Old New Status
mecha_air_tank Added
mecha_bin Added
mecha_camera Added
mecha_chainsword Added
mecha_radio Added
mecha_sleeper Added
mecha_syringegun Added
paddy_claw Added
paddyupgrade Added

Resources/Textures/Objects/Specific/Mech/ripleymkii_construction.rsi

State Old New Status
ripleymkii0 Added
ripleymkii1 Added
ripleymkii10 Added
ripleymkii11 Added
ripleymkii12 Added
ripleymkii13 Added
ripleymkii14 Added
ripleymkii15 Added
ripleymkii16 Added
ripleymkii17 Added
ripleymkii18 Added
ripleymkii19 Added
ripleymkii2 Added
ripleymkii20 Added
ripleymkii3 Added
ripleymkii4 Added
ripleymkii5 Added
ripleymkii6 Added
ripleymkii7 Added
ripleymkii8 Added
ripleymkii9 Added
ripleymkii_chassis Added
ripleymkii_harness+o Added
ripleymkii_harness Added
ripleymkii_l_arm+o Added
ripleymkii_l_arm Added
ripleymkii_l_leg+o Added
ripleymkii_l_leg Added
ripleymkii_r_arm+o Added
ripleymkii_r_arm Added
ripleymkii_r_leg+o Added
ripleymkii_r_leg Added
ripleymkii_upgrade_kit+o Added
ripleymkii_upgrade_kit Added

Edit: diff updated after 12a53c1

@gluesniffler
Copy link
Contributor

gluesniffler commented Oct 7, 2024

Funnily enough I was just working on a quick and dirty PR for this on syndicate station, here's a small list of bugs I found from my testing there:

  • There seems to be misprediction, making weapons fire twice
  • Walk toggles arent working correctly on the mechs, they probably need the CanWalk component.
  • Mechs can wide swing for whatever reason, it drains your stamina and ultimately cant hit anything.
  • If you open the panel and theres no battery on the mech, it crashes the game (because its trying to divide 0 by the 100% of the battery to draw the bar) Fixed by this fix mech energy display for 0 space-wizards/space-station-14#27828

@gluesniffler
Copy link
Contributor

https://github.com/gluesniffler/Einstein-Engines/tree/mechmerges Have the link here too, since the automerge fucks up a lot of YML. This one runs

@github-actions github-actions bot added the Changes: UI Changes any XAML files label Oct 7, 2024
@VMSolidus
Copy link
Member Author

Funnily enough I was just working on a quick and dirty PR for this on syndicate station, here's a small list of bugs I found from my testing there:

  • There seems to be misprediction, making weapons fire twice
  • Walk toggles arent working correctly on the mechs, they probably need the CanWalk component.
  • Mechs can wide swing for whatever reason, it drains your stamina and ultimately cant hit anything.
  • If you open the panel and theres no battery on the mech, it crashes the game (because its trying to divide 0 by the 100% of the battery to draw the bar) Fixed by this fix mech energy display for 0 space-wizards/space-station-14#27828

Weapon misprediction is basegame lol.
Technically the walk toggle shouldn't work at all, and this is an issue with the basegame code.
Here's a shitcode fix for mech wide swing disabling.
And got the fix for the battery crash, thanks!

@FoxxoTrystan FoxxoTrystan added Priority: 3-Medium Needs to be resolved at some point Size: 2-Large For large issues/PRs Type: Port Brings something to here from another codebase labels Oct 7, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Status: Merge Conflict FIX YOUR PR AAAGH label Oct 13, 2024
@FoxxoTrystan
Copy link
Member

Il give a try to also touch on this PR later on, pehaps fix some of the issues to make that PR Ready again.

@FoxxoTrystan FoxxoTrystan requested review from a team, Aidenkrz, FoxxoTrystan, Remuchi, DEATHB4DEFEAT, Peptide90, Pspritechologist and OldDanceJacket and removed request for a team November 8, 2024 15:01
@FoxxoTrystan FoxxoTrystan self-assigned this Nov 8, 2024
@github-actions github-actions bot added the Status: Needs Review Someone please review this label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an RSI Changes: UI Changes any XAML files Changes: YML Changes any yml files Priority: 3-Medium Needs to be resolved at some point Size: 2-Large For large issues/PRs Status: Merge Conflict FIX YOUR PR AAAGH Status: Needs Review Someone please review this Type: Port Brings something to here from another codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants