Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osx: Replace the LLDB parser/engine with a macho-parser + mach-engine #402

Merged
merged 8 commits into from
Aug 16, 2023

Conversation

SimonKagstrom
Copy link
Owner

Improves performance ~20x, making it usable on OSX.

Some remaining issues, which may or may not be solved in the future:

  • dsymutil needs to be run on the binary
  • kcov needs to be signed with the debugger entitlement
  • attaching to a pid does not work
  • covering shared libraries does not work

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.22% 🎉

Comparison is base (a013c1c) 63.98% compared to head (d021250) 64.20%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   63.98%   64.20%   +0.22%     
==========================================
  Files          58       58              
  Lines        4634     4629       -5     
  Branches     4290     4285       -5     
==========================================
+ Hits         2965     2972       +7     
+ Misses       1669     1657      -12     
Files Changed Coverage Δ
src/solib-handler.cc 64.22% <100.00%> (+0.33%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SimonKagstrom SimonKagstrom merged commit 3cbfe23 into master Aug 16, 2023
4 of 14 checks passed
@SimonKagstrom SimonKagstrom deleted the macho-parser branch August 16, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant