Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add Namespace to build.gradle for :flutter_credit_card #171

Merged

Conversation

gapkalov
Copy link
Contributor

@gapkalov gapkalov commented Sep 17, 2024

Issue: Build failed due to missing namespace in the :flutter_credit_card module's build.gradle file.

Solution: Added the required namespace property to build.gradle as specified in Android's documentation.

Outcome: The build now completes successfully without errors.
@meetjanani-simformsolutions @kaoz70 @kika @vHanda @guicarvalho @BirjuVachhani @DevarshRanpara

@gapkalov gapkalov changed the title Conditional for compatibility with AGP <4.2 Fix: Add Namespace to build.gradle for :flutter_credit_card Sep 17, 2024
@kgrabko
Copy link

kgrabko commented Sep 17, 2024

please accept changes to make to work with last flutter

@kgrabko
Copy link

kgrabko commented Oct 18, 2024 via email

Copy link

@kgrabko kgrabko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make fix ASAP please to move to new Flater please

Copy link
Collaborator

@Sahil-Simform Sahil-Simform left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@kaoz70 kaoz70 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, approved

@vatsaltanna-simformsolutions vatsaltanna-simformsolutions merged commit 4929441 into SimformSolutionsPvtLtd:master Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants