✨ Added input decoration class #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vatsaltanna
reviewed
Oct 4, 2023
| @@ -194,9 +194,6 @@ import 'package:flutter_credit_card/flutter_credit_card.dart'; | |||
| expiryDateKey: expiryDateKey, | |||
| cardHolderKey: cardHolderKey, | |||
| onCreditCardModelChange: (CreditCardModel data) {}, // Required | |||
| themeColor: Colors.black, // Required | |||
There was a problem hiding this comment.
please add breaking change section in readme.
manoj-simform
force-pushed
the
docs/readme_changes
branch
5 times, most recently
from
7984540 to
90fa932
Compare
aditya-css
requested changes
Oct 5, 2023
| import 'package:flutter_credit_card/src/utils/constants.dart'; | ||
|
|
||
| class InputConfiguration { | ||
| const InputConfiguration({ |
There was a problem hiding this comment.
Please add documentation comment stating the use of this class.
README.md
Outdated
| ), | ||
| ), | ||
| ``` | ||
|
|
||
| ## Breaking Changes in 4.x.x | ||
| - `themeColor`, `textColor`, and `cursorColor` have been removed from `CreditCardForm` as it can't detect the application theme. Please check out the example app to learn how to apply those using `Theme`. |
There was a problem hiding this comment.
Please mention removal of input decoration fields and how to use in the newer version.
README.md
Outdated
| labelText: 'Expired Date', | ||
| hintText: 'XX/XX', | ||
| ), | ||
| cvvCodeDecoration: const InputDecoration( |
There was a problem hiding this comment.
remove const from InputDecoration widget as it is specified at the parent constructor and thus is not needed.
manoj-simform
force-pushed
the
docs/readme_changes
branch
2 times, most recently
from
c5c0804 to
deee088
Compare
vatsaltanna
reviewed
Oct 5, 2023
CHANGELOG.md
Outdated
| - The `cardNumberDecoration`, `expiryDateDecoration`, `cvvCodeDecoration`, and `cardHolderDecoration` | ||
| properties are moved to the newly added `InputDecoration` class that also has `textStyle` properties | ||
| for all the textFields of the `CreditCardForm`. | ||
| - Updated `readme.md` to have migration guide to Version 4.0.0. |
manoj-simform
force-pushed
the
docs/readme_changes
branch
from
deee088 to
154d5d9
Compare
aditya-css
approved these changes
Oct 5, 2023
vatsaltanna
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.