Added verve brand #145
Open
Added verve brand #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-css
requested changes
Oct 2, 2023
- Added Card Number Pattern for verve cards.
vatsaltanna
reviewed
Oct 3, 2023
| @@ -180,7 +180,7 @@ class _CreditCardFormState extends State<CreditCardForm> { | |||
| late CreditCardModel creditCardModel; | |||
|
|
|||
| final MaskedTextController _cardNumberController = | |||
| MaskedTextController(mask: '0000 0000 0000 0000'); | |||
| MaskedTextController(mask: '0000 0000 0000 0000 000'); | |||
There was a problem hiding this comment.
These changes should be based on the brand, as most of the brands support only 16 digits.
| @@ -281,7 +281,7 @@ class _CreditCardFormState extends State<CreditCardForm> { | |||
| validator: widget.cardNumberValidator ?? | |||
| (String? value) { | |||
| // Validate less that 13 digits +3 white spaces | |||
| if (value!.isEmpty || value.length < 16) { | |||
| if (value!.isEmpty || value.length < 19) { | |||
There was a problem hiding this comment.
These changes should be based on the brand, as most of the brands support only 16 digits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.