Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #446 Weekview does reflect changes to startHour and endHour. #447

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bsutton
Copy link
Contributor

@bsutton bsutton commented Jan 4, 2025

Description

The week view doesn't reflect changes to startHour or endHour when it rebuilds.

Move move both of these values into the InternalWeekView state and update the state when the widget changes.

Checklist

  • [ x] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • [ x] I have followed the Contributor Guide when preparing my PR.
  • [ x] I have updated/added tests for ALL new/updated/fixed functionality.
  • [ x] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [ x] I have updated/added relevant examples in examples or docs.

Breaking Change?

None

Migration instructions

Not required.

  • Yes, this PR is a breaking change.
  • [x ] No, this PR is not a breaking change.

Related Issues

Closes #446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weekview doesn't reflect changes to the start/Hour/endHour
1 participant