Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Support for changing the week day position(top/bottom) in… #284

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

jaiminrana05
Copy link
Collaborator

… weekView #283.

Description

Added a flag [showWeekDayAtBottom] option to change the position of the weekday in the week-view.

showWeekDayAtBottom: false (Default)
image

showWeekDayAtBottom: true
image

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • [] I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Closes #283

@PRBaraiya
Copy link
Collaborator

@jaiminrana05 Please resolve the conflicts in this PR.

@jaiminrana05 jaiminrana05 force-pushed the fix/issue_283_week_day_placement branch from 535ce33 to 8540380 Compare November 23, 2023 12:32
Copy link
Collaborator

@PRBaraiya PRBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PRBaraiya PRBaraiya merged commit 672b2cf into master Nov 23, 2023
1 check passed
@PRBaraiya PRBaraiya deleted the fix/issue_283_week_day_placement branch November 23, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Week Day Placement
2 participants