Fix memory usage when listing roles increasing with user count #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikgamerzclass
force-pushed
the
master
branch
from
5748bca
to
052b779
Compare
henrikgamerzclass
changed the title
|
Thanks very much for your contribution, will get this merged in this afternoon. |
|
Sorry for rushing, but is there an ETA on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently ran into this issue because we have roles attached to more than 86.000 users. The way each role's user count was calculated would load the full user model of all users that has a role, which caused our containers to run out of memory.
This fix changed our memory usage from 1197 MB to 2 MB.