Added model parameter to RolePolicy methods #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would suggest to accept model parameters in
RolePolicy.php
. In that case we are able to extend theRolePolicy.php
to add behavior for specific roles.For example I have created a custom permission
canManageAdminRole
and extended theRolePolicy.php
with a new Policy so that all users without that permission can't view my admin role with ID 1:EDIT:
Added a default permission whether to show the
Roles
resource in dashboard or not.