Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more events to silk-core & silk-paper #62

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MiraculixxT
Copy link
Contributor

@MiraculixxT MiraculixxT commented Sep 1, 2024

Adding more useful events to the silk event system for fabric and paper. This PR should be a share of the current state until enough events are properly implemented worth merging ( #26 ).

Mixins or paper-events where multiple silk events are triggered contains new comment highlighting to optimize readability.

I would be happy about feedback to the current state for better future additions.

Current Additions

  • EntityEvents
    • Item Drop Event (allow cancelling and item entity editing - Bugged in singleplayer worlds for players)
    • Entity Death Event (allow cancelling and loot dropping)
  • PlayerEvents
    • Death Message Event (allow editing death message)
    • Block Break Event (allow canceling)

@MiraculixxT
Copy link
Contributor Author

Maybe its worth adding a silk-testmod module for paper to test the paper implementation. Would this fit into the project?

@jakobkmar
Copy link
Member

Maybe its worth adding a silk-testmod module for paper to test the paper implementation. Would this fit into the project?

I would rather make the testmod a multiplatform module, to show how it can be used for both platforms.

Added on fabric and paper side
@MiraculixxT
Copy link
Contributor Author

I would rather make the testmod a multiplatform module, to show how it can be used for both platforms.

Sounds like a better idea! But this is a task for someone else as I'm still not familiar enough with the workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants