Restore rps build #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commander is able to flash .hex file, but only the one generated by siwx917_isp_prepare.py. The common .hex file, generated from the .elf file are not supported. This reverts commit a448c72. Signed-off-by: Jérôme Pouiller <[email protected]>
siwx917_isp_prepare.py required crc python package. This reverts commit 582dea6. Signed-off-by: Jérôme Pouiller <[email protected]>
Currently, siwx917_isp_prepare.py is generating aan .hex file overwriting the one created by Zephyr. This create confusion and can lead to bugs. Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
force-pushed
the
restore-rps-build
branch
from
52f8083 to
e8bd741
Compare
Martinhoff-maker
approved these changes
Nov 8, 2024
jhedberg
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commander is able to flash .hex file, but only the one generated by
siwx917_isp_prepare.py. The common .hex file, generated from the .elf
file are not supported.
So, restore the original behavior.