-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: Add status badge for upstream daily build #60
README: Add status badge for upstream daily build #60
Conversation
README.md
Outdated
@@ -1,3 +1,5 @@ | |||
[![Silabs upstream daily build](https://github.com/SiliconLabsSoftware/zephyr-silabs/actions/workflows/upstream-build.yml/badge.svg)](https://github.com/SiliconLabsSoftware/zephyr-silabs/actions/workflows/upstream-build.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a rather long line. I believe you can get the same result with:
[![Silabs upstream daily build][badge]][recipe]
[badge]: actions/workflows/upstream-build.yml/badge.svg
[recipe]: actions/workflows/upstream-build.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerome-pouiller sure, thanks. What I initially had was a copy-paste of what GitHub itself offers when you select "Generate badge" in the Actions tab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jerome-pouiller done now, however I trust you that it's actually valid syntax (I'm not a Markdown expert)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at https://github.com/jhedberg/zephyr-silabs/tree/upstream_status_badge it seems to be fine now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone fork zephyr-silab
he will get the status of the upstream repo. It is not a big deal I assume.
6abf63a
to
b57d556
Compare
Add a status badge to indicate whether the upstream daily build is passing or not. Signed-off-by: Johan Hedberg <[email protected]>
b57d556
to
36d6c89
Compare
Add a status badge to indicate whether the upstream daily build is passing or not.