github: workflows: Remove continue-on-error #58
Conversation
We want the workflows to fail for these steps, so remove continue-on-error. Signed-off-by: Johan Hedberg <[email protected]>
|
Note: I'll wait until zephyrproject-rtos/zephyr#80537 has been merged, and then update |
|
The build fails on windows. Probably I shouldn't removed this snippet: |
Indeed. That said, do we think it really adds sufficient value to have macOS and Windows in the CI?. I would expect that upstream takes care of testing that the SDK works on all three platforms. That said, if we ever start introducing non-Zephyr SDK dependencies to our CI workflows (say, Commander or JLink), then I think it'd be important to check that the steps still work on all Zephyr SDK supported operating systems. |
|
The failure on Windows is not introduced by this PR. So, I suggest to merge it. |
This should fix the CI failues we've been having with `west twister`. Signed-off-by: Johan Hedberg <[email protected]>
Upstream should do a good enough job of testing all supported Zephyr SDK OS versions. We can reintroduce macOS and Windows if/when we start doing more advanced things in CI that Zephyr upstream doesn't already do. Signed-off-by: Johan Hedberg <[email protected]>
Instead of complicated grep + sed combinations, simply use the west list command to get the current revision of the zephyr tree. Signed-off-by: Johan Hedberg <[email protected]>
jhedberg
force-pushed
the
workflow_continue_on_error
branch
from
a922d22 to
558d7a1
Compare
I'd have to tweak the repo settings first, since right now it's set so that even an admin can't press the Merge button when there's a failed Check. I went with disabling Windows and macOS instead for now. We can re-enable them later if there's a clear justification for it. |
Don't use "build" since it becomes difficult to distinguish this from the actual build workflows when defining rule sets for the repo. Signed-off-by: Johan Hedberg <[email protected]>
We want the workflows to fail for these steps, so remove continue-on-error.