Add RNG driver #54
Merged
Add RNG driver #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, this PR allow to get rid of this warning when building WiFi example: |
jerome-pouiller
force-pushed
the
siwx917-rng
branch
3 times, most recently
from
856e75c to
be0227f
Compare
jhedberg
approved these changes
Oct 22, 2024
|
Looks good, but I added the DNM label until the HAL PR has been merged and west.yml updated. |
|
|
||
| static int siwx917_get_entropy(const struct device *dev, uint8_t *buffer, uint16_t length) | ||
| { | ||
| return siwx917_get_entropy_isr(dev, buffer, length, ENTROPY_BUSYWAIT); |
There was a problem hiding this comment.
The API description says: "This call has to be thread safe to satisfy requirements of the random subsystem."
There was a problem hiding this comment.
In fact, I believe RSI_RNG_GetBytes() and all the subfunctions (mainly rng_get_bytes()) are thread safe. So I didn't keep the spinlock.
silabs-TiborL
approved these changes
Oct 24, 2024
Support for random number generator is required for most of the
cryptographic operations, including support for WiFi and TLS.
This driver has been tested with tests/drivers/entropy:
*** Booting Zephyr OS build v3.7.0-4339-g1ec5ce05f9f8 ***
Running TESTSUITE entropy_api
===================================================================
START - test_entropy_get_entropy
random device is 0x8217298, name is rng@45090000
0x93
0x3e
0xf1
0x68
0xd4
0x22
0xbf
0x4d
0xad
PASS - test_entropy_get_entropy in 0.012 seconds
===================================================================
TESTSUITE entropy_api succeeded
------ TESTSUITE SUMMARY START ------
SUITE PASS - 100.00% [entropy_api]: pass = 1, fail = 0, skip = 0 ...
- PASS - [entropy_api.test_entropy_get_entropy] duration = 0.01 ...
------ TESTSUITE SUMMARY END ------
===================================================================
RunID: d1547c805699201af769cb01331efcce
PROJECT EXECUTION SUCCESSFUL
Co-authored-by: Tibor Laczko <[email protected]>
Signed-off-by: Tibor Laczko <[email protected]>
Signed-off-by: Jérôme Pouiller <[email protected]>
Change indentation level of build.yml to match upstream-build.yml. Signed-off-by: Jérôme Pouiller <[email protected]>
upstream-build.yml and build.yml didn't invoke twister in the same nor with the same tests. Note $EXTRA_TWISTER_FLAGS was used in all the tests. Yet, CI still runs on Windows. So, this commit get rid of EXTRA_TWISTER_FLAGS in all the invocations. Signed-off-by: Jérôme Pouiller <[email protected]>
It makes sense to check we don't break the entropy driver. Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
force-pushed
the
siwx917-rng
branch
from
be0227f to
47e8a59
Compare
jerome-pouiller
merged commit 49b5a1b
into
SiliconLabsSoftware:main
5 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is inspired of the Tibor's work.
This PR also align build.yml and upstream-build.yml.