Use commander #50
Merged
Use commander #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When commander is called with an .hex file as argument, it is able to generate the RPS information on the fly. So, we can take advantage of this feature and get rid of siwx917_isp_prepare.py. Signed-off-by: Jérôme Pouiller <[email protected]>
Since "commander" has replaced "siwx917_isp_prepare.py", crc python package is no more needed. Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
force-pushed
the
use-commander
branch
from
7d16f66 to
361bdbf
Compare
jhedberg
approved these changes
Oct 21, 2024
asmellby
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of siwx917_isp_prepare.py and use commander instead.