WiFi: allow to use Zephyr native stack #47
Conversation
jerome-pouiller
force-pushed
the
siwx917
branch
from
8c5203a to
c8d719c
Compare
|
v2:
|
jerome-pouiller
force-pushed
the
siwx917
branch
from
c8d719c to
d0c151a
Compare
drivers/wifi/siwx917/siwx917_wifi.h
Outdated
| /* | ||
| * Copyright (c) 2024 Silicon Laboratories Inc. | ||
| * | ||
| * The licensor of this software is Silicon Laboratories Inc. Your use of this |
There was a problem hiding this comment.
Is there a reason to not use Apache-2.0 for this?
There was a problem hiding this comment.
Is there a reason to not use Apache-2.0 for this?
That's indeed a fair question, and if it's not possible to use anything else (at least in the short term), seems like hal_silabs may be a better place for it? It'd be good to keep the code in zephyr-silabs upstreamable at least from a license perspective.
There was a problem hiding this comment.
Since this is a Zephyr implementation that merely uses the Wiseconnect API, I can't think of anything that should block this from having a Zephyr friendly license, even if Wiseconnect iself hasn't been relicensed yet.
| /* | ||
| * Copyright (c) 2024 Silicon Laboratories Inc. | ||
| * | ||
| * The licensor of this software is Silicon Laboratories Inc. Your use of this |
There was a problem hiding this comment.
Is there a reason to not use Apache-2.0 for this?
There was a problem hiding this comment.
Bad habits. I will fix that tomorrow.
| /* | ||
| * Copyright (c) 2024 Silicon Laboratories Inc. | ||
| * | ||
| * The licensor of this software is Silicon Laboratories Inc. Your use of this |
There was a problem hiding this comment.
Is there a reason to not use Apache-2.0 for this?
jerome-pouiller
force-pushed
the
siwx917
branch
from
d0c151a to
ab090ea
Compare
|
v3:
|
WPA3 relies on 802.11w that was not enabled. Signed-off-by: Jérôme Pouiller <[email protected]>
Zephyr only saves a pointer to the memory area provided to net_if_set_link_addr(). So the MAC address has to be stored in a static area (while it was stored in the stack). Signed-off-by: Jérôme Pouiller <[email protected]>
siwx917_wifi.c is currently pretty large while a big part is in fact only used to manage socket API. Split out the socket management and only keep 802.11 management in siwx917_wifi.c. This commit do not introduce any change in the code. The code is only relocated. Signed-off-by: Jérôme Pouiller <[email protected]>
We try to avoid #ifdef when possible, especially in .c files. Signed-off-by: Jérôme Pouiller <[email protected]>
This new mode allows a better compatibility with Zephyr features. Support for offloading is still supported since it can provide better performances in some cases (power and memory consumption). Signed-off-by: Jérôme Pouiller <[email protected]>
Since SiWx917 is able to use natice network stack, some NWP features are not needed anymore. This commit also try to keep WiFi features inside the "#ifdef CONFIG_WIFI_SIWX917" statement. Signed-off-by: Jérôme Pouiller <[email protected]>
Some #ifdef can be easily changed in IS_ENABLED(). Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
force-pushed
the
siwx917
branch
from
ab090ea to
cbf33f4
Compare
This PR is associated to SiliconLabsSoftware/hal_silabs#8. However,
hal_silabschanges are not required for thezephyr-silabschanges.