Siwx917 Wifi improvements #44
Conversation
jerome-pouiller
commented
Sep 23, 2024
jerome-pouiller
commented
- Wifi was broken because of scheduler/clock issue
- Fix support for Ipv6
- Fix CI
| west twister --test sample.basic.helloworld -p siwx917_rb4338a -v --inline-logs $EXTRA_TWISTER_FLAGS | ||
| west twister --test sample.net.wifi -p siwx917_rb4338a -v --inline-logs $EXTRA_TWISTER_FLAGS | ||
| west twister --test sample.net.wifi -p siwx917_rb4338a -v --inline-logs -K $EXTRA_TWISTER_FLAGS |
There was a problem hiding this comment.
Just as a note for the future, twister supports multiple --test arguments, so we should likely just merge these into a single west twister --test ... --test ... command. I've postponed doing it since we have several PRs open which would conflict with such a change.
Another improvement would be to take advantage of GitHub workflow "matrix", so that GitHub would run in parallel the same workflow with different input parameters for each instance. The parameter could e.g. the a specific platform to build against, i.e. this becomes more relevant as we grow the list of platforms covered by our CI.
jerome-pouiller
force-pushed
the
siwx917
branch
from
4d02f4c to
aa546d4
Compare
|
v2:
|
| # WiseConnect create threads with realtime priority. Default (10kHz) clock tick | ||
| # prevent proper use of the system with these threads. | ||
| config SYS_CLOCK_TICKS_PER_SEC | ||
| default 1024 |
There was a problem hiding this comment.
I think 1000 would make more sense (most new WiseConnect examples are also using 1000).
There was a problem hiding this comment.
That seems strange, considering a 32768 Hz clock divided by 32 would give 1024. Are they not running on a low frequency timer (we are not yet, but were planning to)?
drivers/wifi/siwx917/siwx917_wifi.c
Outdated
| */ | ||
| memcpy(out, in, in_len); | ||
| if (in->sa_family == AF_INET6) { | ||
| for (i = 0; i < 4; i++) { |
There was a problem hiding this comment.
Using ARRAY_SIZE would be nicer.
SiWx917 use byte swapped IPv6 addresses. Once fixed, we are properly able to use UDP and TCP connection over IPv6. Signed-off-by: Jérôme Pouiller <[email protected]>
WiseConnect create threads with realtime priority. Default (10kHz) clock tick prevent proper use of the system with these threads. Signed-off-by: Jérôme Pouiller <[email protected]>
siwx917_rb4338a is not listed in the field "platform_allow" of samples/net/wifi/sample.yaml. So we have to pass -K to twister for execution of this test. Wifi capability was also missed from siwx917_rb4338a.yaml. Signed-off-by: Jérôme Pouiller <[email protected]>
jerome-pouiller
force-pushed
the
siwx917
branch
from
aa546d4 to
5757dd5
Compare
|
v3:
|
|
@jerome-pouiller @silabs-TiborL is this good to be merged now? |
@silabs-TiborL,are you able to approve the PR? |
