[SL-UP] Circular callback fix #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when changing speed
jmartinez-silabs
approved these changes
Oct 31, 2024
rcasallas-silabs
approved these changes
Oct 31, 2024
mkardous-silabs
approved these changes
Oct 31, 2024
mkardous-silabs
pushed a commit
that referenced
this pull request
Nov 13, 2024
mkardous-silabs
pushed a commit
that referenced
this pull request
Nov 13, 2024
This reverts commit 078bc30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an attribute access interface to modify the percent setting from changes on the speed setting ONLY when on client WRITE commands to the SpeedSetting attribute.
That way, we break the circular callback chain on percent changes that caused (With a MaxSpeed of 10):
Write PercentSetting: 25 -> Callback SpeedSetting -> 3 -> Callback PercentSetting: 30