-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SL-Only] Adding non icd enabled lock app zap file #74
[SL-Only] Adding non icd enabled lock app zap file #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is necessary. For SIT ICDs ie. the lock app, you can just disable the icd config.
The zap file with the icdm cluster won't impact behavior or compilation if i'm not mistaken.
@@ -0,0 +1,6343 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in lock-common or in lock-app/silabs/..
The matching .matter file is missing too
"isEnabled": 1 | ||
}, | ||
{ | ||
"name": "AddOrUpdateThreadNetwork", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a wifi specific zap file remove this
] | ||
}, | ||
{ | ||
"name": "Thread Network Diagnostics", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a wifi specific zap file remove this
"isEnabled": 1 | ||
} | ||
], | ||
"attributes": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a wifi specific zap file add the missing supported-wifi-bands attribute
] | ||
}, | ||
{ | ||
"name": "Diagnostic Logs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't support diagnostic logs so since this in only used for silabs wifi don't enable it
"storageOption": "RAM", | ||
"singleton": 0, | ||
"bounded": 0, | ||
"defaultValue": "0x7DB3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't support Aliro. so this featuremap should be updated in consequence see
#80
But also in this zap you have all Aliro attributes enabled. Since we don't support it you must disable them
This is no longer needed |
Adding a non icd enabled zap file which will be used for MG24+WF200 build which will have icd disabled