Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSA-CP][ICD] Set MaximumCheckInBackOff to external and fix define guards for… #72

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

mkardous-silabs
Copy link
Contributor

Description

PR addresses two issues in the ICD server code :

  • MaximumCheckInBackOff attribute should have been set to external in the zcl json files. This was not done when the attributes were initially added to the xml.
  • In the ICDManager, a define guard was set to idef when the define was always set to 0 or 1. Updated the guard to correctly check the define value

Only the first comment as functionnal changes. The second is just the generation.
Cherrypick of #36223

CI and generation to validate the changes

… unit test members (#36223) (#36231)

* Fix ICD manager and attributes

* Generated files

* zap regen
@mkardous-silabs mkardous-silabs requested a review from a team as a code owner October 24, 2024 20:48
@mkardous-silabs mkardous-silabs changed the title [CSA-CP[ICD] Set MaximumCheckInBackOff to external and fix define guards for… [CSA-CP][ICD] Set MaximumCheckInBackOff to external and fix define guards for… Oct 24, 2024
@mkardous-silabs mkardous-silabs added the csa-cp This TAG indicates that this commit is a cherry-pick from a CSA commit. label Oct 24, 2024
@jmartinez-silabs jmartinez-silabs merged commit 59328fc into release_2.4-1.4 Oct 25, 2024
11 checks passed
@jmartinez-silabs jmartinez-silabs deleted the cherry-pick/icd_fix branch October 25, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csa-cp This TAG indicates that this commit is a cherry-pick from a CSA commit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants