[SL-UP] Resolve build error for 917NCP #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinez-silabs
approved these changes
Oct 24, 2024
mykrupp
approved these changes
Oct 24, 2024
mkardous-silabs
added
the
sl-up
mkardous-silabs
merged commit c93e36f
into
SiliconLabsSoftware:release_2.4-1.4
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes build errors for 917ncp when additional data advertisement is enabled. This should be upstreamed to CSA master.
#36189 - This PR in CSA master refactored the BLE code. The change that is being pushed in this PR is missing in the CSA PR.
The build error is not seen in CSA as additional data advertisement is disabled by default. But in SLC, the additional data advertisement component is included for 917ncp, so faced the build error.