[CSA-CP] Modify region code for module boards(brd4343a) #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinez-silabs
approved these changes
Oct 24, 2024
|
@arun-silabs Why is there only a single change from the PR and not all the changes? |
All other changes in the CSA PR are related to building apps in gn build system. I've raised this PR just to cherry-pick the fix for init failure with brd4343a. All other changes for adding board support in SLC are already present. |
mkardous-silabs
requested changes
Oct 24, 2024
Done, cherry-picked all the changes |
mkardous-silabs
approved these changes
Oct 24, 2024
mkardous-silabs
added
csa-cp
mykrupp
merged commit 779fb67
into
SiliconLabsSoftware:release_2.4-1.4
11 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks the fix for wifi init failure for brd4343a. This change has been merged in CSA master(#36111)
project-chip/connectedhomeip#36111