[SL-UP] Update WiseConnect to v3.3.3 #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arun-silabs
changed the title
mykrupp
reviewed
Oct 17, 2024
.gitmodules
Outdated
| @@ -223,7 +223,7 @@ | |||
| [submodule "third_party/silabs/wifi_sdk"] | |||
| path = third_party/silabs/wifi_sdk | |||
| url = https://github.com/SiliconLabs/wiseconnect.git | |||
| branch = v3.3.2 | |||
There was a problem hiding this comment.
This isn't necessary to do in matter_sdk, if we want to do this update it should be done in CSA. We use the wifi_sdk from the matter_extension, so we can still comeplete the task to move to 3.3.3 by updating matter_extensions wifi_sdk submodule.
mykrupp
reviewed
Oct 17, 2024
third_party/silabs/matter_support
Outdated
There was a problem hiding this comment.
Same comment on this, these should only be updated in CSA.
mykrupp
reviewed
Oct 17, 2024
third_party/silabs/wifi_sdk
Outdated
There was a problem hiding this comment.
Same comment on this, these should only be updated in CSA.
mkardous-silabs
requested changes
Oct 18, 2024
There was a problem hiding this comment.
@arun-silabs We can still cherry-pick changes to th matter v1.4 branch. Instead of a cherry-pick PR, please open a PR to port these changes to CSA v1.4 branch once the PR towards master is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes required for updating WiseConnect to 3.3.3.