Current csa #53
Closed
Current csa #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mykrupp
commented
Oct 15, 2024
mykrupp
commented
* Add TC_CCTRL_2_1 to CI * Add TC_CCTRL_2_2 to CI * Fix copy-paste typo * Allow to override test runner YAML options with command line options * Add TC_CCTRL_2_3 to CI * Run tests on CI * Add MCORE.FS to PICS.yaml
The default for the build environment shoudl be in the out dir since that's already excluded from git. Makes things easier for people following the documentation for the first time who won't necessarily change that directory to their preferred location.
…ute (#35903) * Added a new server-side optional attribute `TCUpdateDeadline` (code 0x09) to the General Commissioning Cluster XML. * This attribute is a 32-bit unsigned integer (`int32u`) and is marked as non-writable. * The attribute is defined as provisional with `apiMaturity="provisional"`. * It includes read access with the privilege set to administer. * Re-generated using ./scripts/tools/zap_regen_all.py
…control (#35862) * Add separate listing for device types * Make unit tests work * Restyle * Fixup include * Fixup include * Make use of DataModel::Provider when doing device type resolution * Add clang-tidy comments * Fix merge error: duplicate declaration * Fix a few more merge conflict markers --------- Co-authored-by: Andrei Litvin <[email protected]>
* Add missing feature map bit * Generation
…t ids. (#35920) Makes it easier to tell what commands are being sent, and what attributes are being written.
1) For request paths, clearly mark wildcards instead of logging 0. 2) For all paths except command paths, when we have a value (cluster id, attribute id, event id) that we can find a string representation for, log that string representation. Command paths are a bit complicated because we have to know whether this is a request or a response and we don't have that information in MTRCommandPath at the moment. Will be done in a followup.
IDs are unsigned; we should not be formatting them with %d, because for vendor-prefixed ones that might make them look negative.
Things got a bit too copy/pasted.
…s (#35907) * tv-casting-app fix loading stale binding endpoints from un-needed fabrics * Fixing style issues * Addressed comments by sharadb-amazon * Addressed comments by sharadb-amazon 2 * Addressed comments by sharadb-amazon 3
…command (#35926) * Use ScheduleLambda() instead of PlatformMgr().ScheduleWork to excute command * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
* Enable MRP in WiFi-PAF commissioning Signed-off-by: Lo,Chin-Ran <[email protected]> * Restyled by clang-format --------- Signed-off-by: Lo,Chin-Ran <[email protected]> Co-authored-by: Restyled.io <[email protected]>
* [Linux] Matter Linux Water Leak Detector Example * Update README.md Remote Echo protocol section * Update water-leak-detector-app.zap * Symlinks * New sym links * Update README.md Fix typo * Create water-leak-detector-app.matter * Update water-leak-detector-app.matter Remove last line * Update README.md * Update water-leak-detector-app.matter * Update water-leak-detector-app.zap * Update water-leak-detector-app.matter * Update water-leak-detector-app.zap * Update water-leak-detector-app.matter * Delete examples/water-leak-detector-app/linux/README.md * Update targets.py to add WATER_LEAK_DETECTOR * Update host.py to add WATER_LEAK_DETECTOR * Update water-leak-detector-app.matter Fix ThreeLevelAutoEnum * Update all_targets_linux_x64.txt Add water-leak-detector
* Added WebRTC Requestor cluster xml file and associated references * Generated using ./scripts/tools/zap_regen_all.py * Fixed command descriptions. * (re)Generated using ./scripts/tools/zap_regen_all.py * (re)Generated using ./scripts/tools/zap_regen_all.py
…llers to the concrete controller class. (#35943) These APIs are never used for XPC controllers, and the base class implementation does not really make sense.
…oncrete. (#35945) The base class implements these selectors already, and its implementation is perfectly fine.
* Add a size-display script for binaries. I am currently looking to investigate sizes of our code given the CodegenDataModel work, so adding a script that can display a nice treemap of things received from NM. It is generally hacked-up to display ok data for matter binaries. (i.e. it splits emberAf and Matter as separate entities). It is currently a best-effort. * Restyled by autopep8 * Restyled by isort * Support some zoom and better parenting * Restyled by autopep8 * Update parenting and fix up auto-format * Fix up call suffixes if they contain namespaces * Remove debug print, fix up vtable and thunk * Allow stripping of entire sections - the C section is large and generally not that useful * Strip C by default * Undo default strip: we likely should show the full size because C libs are non-trivial in size --------- Co-authored-by: Restyled.io <[email protected]>
There isn't actually a _cppCommissioner on the base controller, so that implementation made no sense. In practice, the XPC and concrete controller just have different implementations here, and the base should not try to implement anything. Also fixes the concrete implementation to avoid a sync dispatch by caching the value (which should be immutable) during startup and removes the unnecessary controllerNodeId override from the concrete controller: the base class handles that backwards compat shim already.
…35947) MTROperationalCredentialsDelegate always works with a concrete controller. Make that explicit. At that point, asyncGetCommissionerOnMatterQueue can only get called on an MTRDeviceController from and MTRBaseDevice that was created for an XPC controller. Having that just fail out is perfectly reasonable.
…target board (#35952)
…ithout `ember-compatibility-functions.cpp` (#35919) * Add ability to skip compiling of ember-compatibility-functions * Fix build and make sure that CI will validate a data-model-enabled build * Restyle * Fix compilation * Restyled by clang-format * Typo fix * Fix includes * Rename method to something that seems a bit clearer * Fix pwrpc usage to use datamodel interface * Restyle * Remove todo * Update for attribute is list to support not know value * Update src/app/WriteHandler.h Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
* [Fabric-Bridge] Replace ScheduleWork with ScheduleLambda * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
…Time ICDs (#35956) * Remove optional spec check * Add static_assert for the slow poll config for SIT ICDs * Add missing include * fix restyler error * fix spacing * Remove client build flag since it is not used
…round (#35950) * Make function argument a reference, to avoid passing in struct data around * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
…most the sa… (#36043) * Reduce the amount of target build by the ci why keeping almost the same code coverage * Fix missing target change in bloat report
Not everything got updated correctly when endpoint indices changed from uint8 to uint16. Fixes project-chip/connectedhomeip#36007
…ge::Run to make the memory graph cleaner (#36046)
* Dead code, no longer needed * Restyled by clang-format --------- Co-authored-by: Restyled.io <[email protected]>
* Improve ICDClientStorage -- when DeleteAllEntries is triggered, and all fabric are removed, we need remove ICDFabricList from persistent storage, if there is at least 1 fabric in table, we would update fabricList vector and persistent storage. -- when fabric does not exist, storeEntry needs to return invalid fabric error, and deleteEntry or deleteAllEntries needs to return no error. -- Add multiple unit tests to cover DeleteAllEntries/StoreEntry/CheckInHandling for multiple fabrics * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * Update DefaultICDClientStorage.cpp Co-authored-by: mkardous-silabs <[email protected]> * address comments * Restyled by whitespace * Restyled by clang-format * address comments * address comments and add more tests * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: mkardous-silabs <[email protected]> Co-authored-by: Restyled.io <[email protected]>
* Definition of the Camera AV StreamManagement Cluster. Define StreamTypeEnum in global-enums.xml, moving from WebRTC Provider cluster and AV Stream Management. Spec in `cameras` branch. Draft PR: CHIP-Specifications/connectedhomeip-spec#10004 * Keep the jclass and its corresponding constructor jmethod inside a scope block. This is to prevent duplicate declaration error when multiple variables of the same struct type are present. * Auto-generated files from zap-regen for Camera AV Stream Management.
* [Python] After SubscriptionTransaction has an error, calling Shutdown() will crash * Add a comment * update comment
…(#32817) * fix arm64 build failure when bluetooth enabled on linux platform * Use C++ keyword for getting type --------- Co-authored-by: sabollim <[email protected]> Co-authored-by: Arkadiusz Bokowy <[email protected]>
…p: Add comment explaining the use of isinstance for list detection (#36063)
… iOS. (#36062) * [darwin-framework-tool] Add a step in CI to ensure darwin-framework-tool can be built on iOS * [darwin-framework-tool] Build fixes
* MCORE-FS-1.4: Wait for dynamic endpoint to appear on TH_FSA Fixes #35348 * Timeout for getting dynamic endpoint
…(#36064) * [Matter.framework] Follow-up to address remaining issues from #36015 * Update src/darwin/Framework/CHIP/MTRBaseDevice.mm Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Boris Zbarsky <[email protected]>
…(#36069)
There were some errors in the xml generation for some of the later
spec changes in PR#35841.
Note: The auto-generated code merged in is correct and reflect the latest
spec changes to the cluster.
…nstead of a global shared storage (#36044)
…ubfolders (#34233) * Move files and add indexes * Fix references for new paths * Fix references * Fix up some new references * move darwin back into guides * remove darwin from platforms * Restyled by prettier-markdown * whoops, didn't save * Restyled by prettier-markdown * fix dishwasher readme * fix boufallolabs readme * fix links --------- Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
The prefix is redundant because these are all Matter device types anyway, and is not present in the spec.
Introduce the following flags: - CONFIG_APP_BUTTON_ENABLED - flag to configure if ButtonApp instance is registered. - CONFIG_BLE_BUTTON_ENABLED - flag to configure if ButtonBle instance is registered. - CONFIG_APP_BUTTON_HANDLE_SDK_PREDEFINED - flag to configure if the button handle is predefined in the SDK or not. If not set, the handle will be defined and initialized explicitly in the file. Signed-off-by: marius-alex-tache <[email protected]>
* TC-DA-1.2: Better error messages
Test: Added a bad der file in the cd-certs dir, saw failure on
ToT, no failure with this fix.
* whoops, forgot to add this change
* linter
- Set default brightness to 100% out of box (like most real light bulbs) rather than 1 or even 0 (illegal). - Set the MinLevel and MaxLevel to legal values everywhere they were not. Testing done: - All of CI still passes - Samples react more like real lights
* Fix constraint check in thermostat cluster to follow the spec. The cluster was excluding valid SystemMode values. * Add more test coverage, per review comment. * Removing incorrect copy/pasted comment. * Address one more review comment: need EnsureKnownEnumValue so that all unknown incoming values become the canonical one. * Turn off new test for chip-repl, since it does not support the needed functionality.
* Use standard std::min std::max functions * Restyled by clang-format * Convert some more max calls * More updates * Another fix * Add missing include --------- Co-authored-by: Restyled.io <[email protected]>
* Replace nlSTATIC_ASSERT_PRINT with static_assert * Remove unnecessary includes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.