[SL-ONLY] Add custom rules to selective listening #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkardous-silabs
added
the
sl-up
jmartinez-silabs
approved these changes
Dec 10, 2024
lpbeliveau-silabs
approved these changes
Dec 10, 2024
Co-authored-by: lpbeliveau-silabs <[email protected]>
Co-authored-by: Ricardo Casallas <[email protected]>
mkardous-silabs
changed the title
mkardous-silabs
added
sl-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fixes Selective Listening to work with ecosystems with uniques behavior; in this case, the homdepod mini.
The homepod has two particular devices:
To fix the first limitation, we register the ApplicationSleepManager with the ICDManager to get notified of transition from ActiveMode to IdleMode. There is no other mechanism at the moment to know when the fail safe timer gets armed or disarmed. In a follow up, the Application SleepManager can be simplified since it covers the commissioning as well.
To fix the second issue, the PR adds a custom rule set to to cover special use cases that would prevent the device from going to LI based sleep. In the case of apple, we do extra checks on the fabrics to validate that we can go to LI based sleep even if we only have a single subscription for two fabrics.
In a follow up, we should introduce a rule template that can be implemented by different "rules engine" to simplfy the maintenance and adding new checks. The way is done right now has a lot of overhead.
Tests
Manual tests with apple