[SL-UP] Fix Wi-Fi Sleep Manager commissioning progress check from clean boot #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkardous-silabs
added
the
sl-up
jmartinez-silabs
approved these changes
Dec 9, 2024
lpbeliveau-silabs
approved these changes
Dec 9, 2024
rcasallas-silabs
approved these changes
Dec 9, 2024
mkardous-silabs
force-pushed
the
fix/selective_listening
branch
from
34d7ec2 to
535a421
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the commissioning complete event gets called for a succesful commissioning, the commissioning stopped callback doesn't get called. Due to this behavior, the
mIsCommissioningInProgressmember never gets reset which prevents us from ever going to LI based sleep in a standard run.This was missed because it requires a clean run from commissioning to a subscribe attempt which apperently i missed.
PR adds a the PowerEvent data that can be passed to the WifiSleepManager to update the commissioning state.
Tests
Run a full sequence from start to finish without power cycling