[SL-UP]Fix SoC build if disable button and led components #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selissia
approved these changes
Dec 4, 2024
jmartinez-silabs
approved these changes
Dec 5, 2024
mkardous-silabs
approved these changes
Dec 6, 2024
bhmanda-silabs
force-pushed
the
fix/soc_build_if_disable_button_led
branch
from
9be57eb to
c198cb4
Compare
mkardous-silabs
merged commit f96399a
into
SiliconLabsSoftware:release_2.5-1.4
11 of 12 checks passed
| @@ -191,6 +197,12 @@ uint8_t SilabsPlatform::GetButtonState(uint8_t button) | |||
| { | |||
| return (button < SL_SI91x_BUTTON_COUNT) ? sButtonStates[button] : 0; | |||
| } | |||
| #else | |||
There was a problem hiding this comment.
this can be merged into one line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compilation fix with 917 SoC if button/LED components are disabled.
Added proper macros wherever button/led code is present.
Tested build locally with BRD4338A board.