[SL-ONLY] Add business logic for the selective listening impl #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkardous-silabs
added
the
sl-only
lpbeliveau-silabs
approved these changes
Nov 27, 2024
Co-authored-by: lpbeliveau-silabs <[email protected]>
|
Just a suggestion, since we are adding the sleep requirement on window open and window close which can be changed, since this is only needed during the commissioning. After commissioning if window is opened or closed the device can be in the DTIM sleep. |
@chirag-silabs I don't follow your suggestion |
rcasallas-silabs
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR implements the
CanGoToLIBasedSleepwhich is the core of the of the Selective Listening Design.The initial logic is to check that there is at least 1 subscription per fabric and that the commissioning window is not opened to enable LI based sleep.
PR removes the dependency on the CommissioningWindowManager because the window is considered open while the
OnCommissioningWindowClosedcallback is being processed.Tests
Manual tests to validate that device is in LI / DTIm based sleep at the right moments. The way the Wi-Fi integration is implemented prevents from having unit tests. This will be in a follow up once the platform layer is improved.