Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SL-UP] Adds and updates logs for RS911X #137

Merged
merged 4 commits into from
Dec 2, 2024
Merged

[SL-UP] Adds and updates logs for RS911X #137

merged 4 commits into from
Dec 2, 2024

Conversation

rosahay-silabs
Copy link
Contributor

@rosahay-silabs rosahay-silabs commented Nov 27, 2024 •
edited
Loading

This PR aims to add error status codes for RS911x with respect to MATTER-4193

@rosahay-silabs rosahay-silabs requested a review from a team as a code owner November 27, 2024 11:19
mkardous-silabs
mkardous-silabs previously approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@mkardous-silabs mkardous-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If are updating the error / progress level of certain logs, can we double check the other prints to make sure they have the correct level as well?

@mkardous-silabs mkardous-silabs added the sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release. label Nov 27, 2024
@mkardous-silabs mkardous-silabs dismissed their stale review November 27, 2024 18:10

Change was introduced which seems unrealted to the initials PR goal

@rosahay-silabs rosahay-silabs changed the title [SL-UP] Adds updated RS911x logs [SL-UP] Adds or updates logs for RS911X Dec 2, 2024
@rosahay-silabs rosahay-silabs changed the title [SL-UP] Adds or updates logs for RS911X [SL-UP] Adds and updates logs for RS911X Dec 2, 2024
@agarwal57 agarwal57 merged commit 79875e8 into SiliconLabsSoftware:release_2.5-1.4 Dec 2, 2024
11 of 12 checks passed
@rosahay-silabs rosahay-silabs deleted the bugfix/rs9116-update-logs branch December 7, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-silabs chirag-silabs chirag-silabs approved these changes

@mkardous-silabs mkardous-silabs mkardous-silabs approved these changes

@senthilku senthilku senthilku approved these changes

Assignees
No one assigned
Labels
sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rosahay-silabs @senthilku @mkardous-silabs @chirag-silabs @agarwal57