[SL-UP] Remove the ActiveSubscription flag when the ReadHandler is being destroyed
#134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkardous-silabs
added
the
sl-up
lpbeliveau-silabs
approved these changes
Nov 26, 2024
rcasallas-silabs
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
OnSubscriptionTerminatedcallback is called, the readhandler that is being destroyed is still marked as active even if the destructor has been called.Due to this, if we want to check the state of the different subscription for the fabric, the readhandler that is being destroyed skews the results since it is marked as active.
PR removes the
ActiveSubscriptionflag before calling theOnSubscriptionTerminatedto avoid having false positives when checking for active subscriptions on the fabric afterwards. This also prevents theOnSubscriptionTerminatedto be called twice if for some reason the destructor is called twice we shouldn't happen.Tests
CI