Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SL-UP] Fix builds for sleep manager #128

Merged
merged 4 commits into from
Nov 25, 2024
Merged

[SL-UP] Fix builds for sleep manager #128

merged 4 commits into from
Nov 25, 2024

Conversation

bhmanda-silabs
Copy link
Contributor

  • While adding wifi sleep manager component in extension , build and copy contents are failing for EFR and SoC platforms.
  • Added CHIP_CONFIG_ENABLE_ICD_SERVER macro, wherever WifiSleepManager.h is included.

@bhmanda-silabs bhmanda-silabs requested a review from a team as a code owner November 25, 2024 13:29
@bhmanda-silabs bhmanda-silabs changed the title Add/sleep manager for icd [SL-UP] Fix builds for sleep manager Nov 25, 2024
@mkardous-silabs mkardous-silabs added the sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release. label Nov 25, 2024
lpbeliveau-silabs
lpbeliveau-silabs approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@lpbeliveau-silabs lpbeliveau-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but in the long term we might want to look into implementing WifiSleepManager in a way that is is stubbed when not building for ICD rather than relying on having #if conditions everywhere.

src/platform/silabs/wifi/SiWx/WifiInterface.cpp Outdated Show resolved Hide resolved
@mkardous-silabs mkardous-silabs merged commit b156273 into SiliconLabsSoftware:release_2.5-1.4 Nov 25, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkardous-silabs mkardous-silabs mkardous-silabs approved these changes

@lpbeliveau-silabs lpbeliveau-silabs lpbeliveau-silabs approved these changes

Assignees
No one assigned
Labels
sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhmanda-silabs @mkardous-silabs @lpbeliveau-silabs