Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-ONLY] Silabs tracing integration #122

Merged
merged 12 commits into from
Nov 26, 2024

Conversation

lpbeliveau-silabs
Copy link
Contributor

@lpbeliveau-silabs lpbeliveau-silabs commented Nov 21, 2024

Integrating our SillabsTracing with the matter tracing backend as well as with our bootup and ota.

Currently needs testing for OTA, timing at bootup is only registered as 0.

Matter backend only logs Sigma 2 and the end of case sessions, need to improve our instrumenting there.

In short, todos are:

  • Integration in apps other than lighting app / refactor our base app to to it by default.
  • Wapper around our System::SystemClock().GetMonotonicTimestamp() in SilabsTracer to use hardware timers before the Scheduler start
  • Wrapper around our SilabsTracer calls to reduce all the #if calls
  • Implementation of NVM storage for Watermarks and Maybe for certain traces
  • Integrate with slc
  • FIgure out metric_event_handler.slcc

@lpbeliveau-silabs lpbeliveau-silabs requested a review from a team as a code owner November 21, 2024 22:51
@lpbeliveau-silabs lpbeliveau-silabs force-pushed the feature/silabs-tracing-integration branch 2 times, most recently from c25e825 to b64e7b7 Compare November 22, 2024 13:15
… in our bootloader and at bootup, timer needs to be figured out.
@lpbeliveau-silabs lpbeliveau-silabs force-pushed the feature/silabs-tracing-integration branch from b64e7b7 to a65940b Compare November 22, 2024 15:16
…ply tracing to other apps as well after review of potential app refactor
@mkardous-silabs
Copy link
Contributor

@lpbeliveau-silabs @jmartinez-silabs Do we want to keeep adding sl-only for these types of changes?

@jmartinez-silabs
Copy link
Contributor

Easier for now we can decide what we upstream later

examples/platform/silabs/BaseApplication.cpp Show resolved Hide resolved
examples/platform/silabs/BaseApplication.h Show resolved Hide resolved
examples/platform/silabs/MatterShell.cpp Outdated Show resolved Hide resolved
examples/platform/silabs/MatterShell.cpp Outdated Show resolved Hide resolved
examples/platform/silabs/MatterShell.cpp Outdated Show resolved Hide resolved
examples/platform/silabs/BaseApplication.h Outdated Show resolved Hide resolved
examples/platform/silabs/MatterShell.cpp Outdated Show resolved Hide resolved
examples/platform/silabs/efr32/BUILD.gn Outdated Show resolved Hide resolved
examples/platform/silabs/main.cpp Outdated Show resolved Hide resolved
examples/platform/silabs/main.cpp Outdated Show resolved Hide resolved
examples/platform/silabs/main.cpp Outdated Show resolved Hide resolved
src/platform/silabs/tracing/BackendImpl.h Outdated Show resolved Hide resolved
src/platform/silabs/tracing/Diagram.mmd Outdated Show resolved Hide resolved
src/platform/silabs/tracing/SequenceDiagram.mmd Outdated Show resolved Hide resolved
src/platform/silabs/tracing/SilabsTracing.cpp Show resolved Hide resolved
@lpbeliveau-silabs lpbeliveau-silabs merged commit 575d44c into release_2.5-1.4 Nov 26, 2024
11 of 12 checks passed
@lpbeliveau-silabs lpbeliveau-silabs deleted the feature/silabs-tracing-integration branch November 26, 2024 19:55
@mkardous-silabs mkardous-silabs added the sl-only This TAG indicates that this commit is a silabs-specific commit that cannot be upstream to CSA. label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sl-only This TAG indicates that this commit is a silabs-specific commit that cannot be upstream to CSA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants