Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-UP] Add fabric subscription check to the interaction model engine #117

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

mkardous-silabs
Copy link
Contributor

@mkardous-silabs mkardous-silabs commented Nov 20, 2024

Description

PR adds a function that checks if a given fabric has at least 1 active subscriptions
This is necessary for the selective listening design to validate that for each fabric we have at least one subscription.

Tests

Unit tests

@mkardous-silabs mkardous-silabs added the sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release. label Nov 20, 2024
@mkardous-silabs mkardous-silabs requested a review from a team as a code owner November 20, 2024 22:00
@mkardous-silabs mkardous-silabs merged commit d0e8630 into release_2.5-1.4 Nov 21, 2024
11 of 12 checks passed
@mkardous-silabs mkardous-silabs deleted the sl-up/add_subscription_fabric_check branch November 21, 2024 01:49
mkardous-silabs added a commit that referenced this pull request Dec 14, 2024
…east 1 subscription (#36627)

* [SL-UP] Add fabric subscription check to the interaction model engine (#117)

* Remove unwanted change

* Restyle

* Improve readability

* Restyled by clang-format

* Update src/app/SubscriptionsInfoProvider.h

Co-authored-by: lpbeliveau-silabs <[email protected]>

---------

Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: lpbeliveau-silabs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants