Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SL-UP] Add brd4357a support #115

Merged
merged 4 commits into from
Nov 25, 2024
Merged

[SL-UP] Add brd4357a support #115

merged 4 commits into from
Nov 25, 2024

Conversation

arun-silabs
Copy link
Contributor

This PR adds the required changes for adding brd4357a support.

  • In this PR, the efx32_ncp_host.c file is modified. We are maintaining a copy of efx32_ncp_host.c file from Wiseconnect and adding pre and post SPI transfer calls needed for LCD.
  • With the existing file in matter_sdk (which is a copy from Wiseconnect v3.1.1), observing SPI_BUSY error for brd4357a. If we use the efx32_ncp_host.c file from latest Wiseconnect release, the error is not seen. So, updated this file from Wiseconnect and added pre and post spi transfer calls in it.

@arun-silabs arun-silabs requested a review from a team as a code owner November 19, 2024 18:03
mkardous-silabs
mkardous-silabs reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@mkardous-silabs mkardous-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a jira teciket to track the porting the changing to the efx32_ncp_host.c file in the wifi sdk?

src/platform/silabs/wifi/SiWx/WifiInterface.cpp Show resolved Hide resolved
src/platform/silabs/wifi/rs911x/platform/efx32_ncp_host.c Outdated Show resolved Hide resolved
@mkardous-silabs mkardous-silabs added the sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release. label Nov 19, 2024
@arun-silabs
Copy link
Contributor Author

Do we have a jira teciket to track the porting the changing to the efx32_ncp_host.c file in the wifi sdk?

Yes, WIFISDK-1099

@mkardous-silabs mkardous-silabs merged commit 4ba638c into SiliconLabsSoftware:release_2.5-1.4 Nov 25, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkardous-silabs mkardous-silabs mkardous-silabs approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

Assignees
No one assigned
Labels
sl-up This TAG indicates that this commit needs to be upstreamed to CSA before its next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arun-silabs @jmartinez-silabs @mkardous-silabs