[SL-UP] Remove two algo design for the wifi retry mechanism #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkardous-silabs
added
the
sl-up
jmartinez-silabs
approved these changes
Nov 14, 2024
|
Careful with the upstream. the restyle part brings changes to the retrieve script. |
rcasallas-silabs
approved these changes
Nov 14, 2024
lpbeliveau-silabs
approved these changes
Nov 14, 2024
mkardous-silabs
added a commit
that referenced
this pull request
Dec 14, 2024
…6628) * [SL-UP] Remove two algo design for the wifi retry mechanism (#103) * [SL-UP] Rename ot interval to transport interval (#108) * [SL-UP] Delete unnecessary double abstraction for the wiseconnect power save functions (#109) * [SL-UP] Update spi-multiplex header inclusion (#110) * [SL-UP] Fix Builds after Wi-Fi interface refactor (#111) * [SL-UP] Remove WF200 define duplication to avoid value conflicts at runtime (#126) * fix spacing * restyle * Fix define name * add missing function * Fix wf200 ICD build * Restyled by clang-format * Add debug config * Re added sem check --------- Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wi-Fi reconnect logi had two different methodologies : One during commissioning and one for standard operations. Having this double logic is unecessary and the fibonnaci like design is sufficient.
The commissioning design also required access to the BaseApplication which is in the app layer which is not accessible from the platform layer.
There will be a follow up PR to implement a true fibonnaci retry mechanims since the current design just doubles the retry interval