-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update main from csa::master #100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ScheduleWork by removing LockChipStack and UnlockChipStack in SensorTimerEventHandler. * Restyled by clang-format * Modified the API name as suggested. * Posting SensorTimerEventHandler as an event to AppTask. --------- Co-authored-by: Restyled.io <[email protected]>
…36211) * Updates verification steps, removes pre-condition * Fix restyle * Fix restyle * Fix restyle * Fix restyle * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <[email protected]>
* add temperature control cluster impl for laundry washer * add washer mode reader writer * remove extra import * fix style * Restyled by clang-format * update temperature level * string span; OnOff DF feature; * Restyled by clang-format * copyright year * static assert * Restyled by clang-format * return error * verify and return * Restyled by whitespace --------- Co-authored-by: Restyled.io <[email protected]>
* Add ICD shell and make Light-switch LIT ICD * remove zcl changes * Move and rename shell files * Move ICD shells files * Start the shell structure refactor * Add lit-icd light-switch zap file * Add missing define guard * Add comment * Address review comments * remove empty change * fix gn file * Add missing include dir * zap generation * Update docker image version * restore zap templtes * Pull latest docker image * zap generation
* [Darwin] VID and PID accessors to MTRDevice - Exposes VID/PID on MTRDevice as API * apply restyle suggestions --------- Co-authored-by: Kiel Oleson <[email protected]>
…ead-by-id and write-by-id commands (#36243) * [darwin-framework-tool][use-mtr-device] Add an option to send command using an MTRDevice instead of a MTRBaseDevice * [darwin-framework-tool][use-mtr-device] Add an implementation for reading attributes via an MTRDevice * [darwin-framework-tool][use-mtr-device] Add an implementation for writing attributes via an MTRDevice
* Removes yaml script * Fix restyle * Fix restyle
…Device_Concrete. (#36224) * Add some machinery for structural validation in MTRDevice_XPC and MTRDevice_Concrete. Validate things that get injected (that we got from the XPC transport) as well as various bits in MTRDevice_XPC. * Address review comments. * Update src/darwin/Framework/CHIP/MTRDeviceDataValidation.mm --------- Co-authored-by: Justin Wood <[email protected]>
* make more detailed logging optional in the codegen data model and enable it only on known large platforms * Update src/app/common_flags.gni Co-authored-by: Boris Zbarsky <[email protected]> * Restyled by gn --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Restyled.io <[email protected]>
* Added Chime Server * Generated using ./scripts/tools/zap_regen_all.py * Restyled by whitespace * Restyled by clang-format * Addressed review comments, storing attributes in server now * (re)Generated using ./scripts/tools/zap_regen_all.py * playChimeSound -> PlayChimeSound * Changed entries in zcl files * (re)Generate using ./scripts/tools/zap_regen_all.py * Restyled by clang-format * (re)Generated by ./scripts/tools/zap_regen_all.py --------- Co-authored-by: Restyled.io <[email protected]>
…#36250) * added sl_matter_test_event_trigger_config for SLC use case * Restyled by clang-format * condition fix --------- Co-authored-by: Restyled.io <[email protected]>
…ningWindowManager. (#36255)
…… (#36194) * [darwin-framework-tool] Make the issuerId of the root certificate constant * [darwin-framework-tool] Use per commissioner storage by default instead of shared storage
…der to save flash (#36247) * This saves 136 bytes... * More changes to save slightly more flash for code * Restyle * Fix typo * Fix includes --------- Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
…td::optional (#36246) * Use a pointer for the subject descriptor. This seems to save about 88 bytes of flash on a test NRF board. * Restyle * Fix include * Fix include * Also fix PW rpc --------- Co-authored-by: Andrei Litvin <[email protected]>
Don't try to build against the library, and don't check out the submodule for the darwin platform.
…roller storage (#36269)
* Googletest as a variant in build_examples.py * Fix unit tests * A bit more cleanup * Apply some updates from Arkadiusz * Remove extra arg
* Use chip::app::IsSignedAttributeType * Fix up put as well as naming for null value and comment * Fix up nullable tests * Test that you cannot decode a null value for non-nullable double and single * Allow NAN for non-nullable floating points * Add test case for non nullable bool * Restyle * Add a header for efr32 * Update src/app/codegen-data-model-provider/EmberAttributeDataBuffer.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Update src/app/codegen-data-model-provider/EmberAttributeDataBuffer.cpp Co-authored-by: Boris Zbarsky <[email protected]> * Remove extra comment * Replace switch with if * Comment fix * Another try to make efr32 build of tests happy * Move includes around, to try to work around issues within efr32 compiles... * more updates, this time local efr32 compiles --------- Co-authored-by: Boris Zbarsky <[email protected]>
…fficult to modify command with backspace (#36267)
…eter to the storage view command to only show the entries for a given commissioner (#36244)
* Adding python code for granating data model xml .gni file * Fixed python code and remove buildable * Update src/python_testing/matter_testing_infrastructure/generate_data_model_xmls_gni.py Co-authored-by: Andrei Litvin <[email protected]> * Update src/python_testing/matter_testing_infrastructure/generate_data_model_xmls_gni.py Co-authored-by: Andrei Litvin <[email protected]> * Update src/python_testing/matter_testing_infrastructure/generate_data_model_xmls_gni.py Co-authored-by: Andrei Litvin <[email protected]> * Fixed mismatches and typo from suggestion commits * Fixed file configuraton to figure out the right directory, so this can be run from anywhere * Restyled by autopep8 * Restyled by isort * Update src/python_testing/matter_testing_infrastructure/generate_data_model_xmls_gni.py --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]>
We should not be comparing strings by pointer value.
… files (#36460) * Split source between wifi platforms * Brake out wiseconnect specific code from the common abstraction * move power save function to specific interface * Remove hw state from extern C * Remove power save call form extern C * Remove unnecessary include * Restyle * Fix ifdef c++ include guards
… it supports. (#36459) It turned out to be easy to use it for some struct type and get weird behavior; we should not allow that to compile.
* changing deprecated GN flag * Restyled by shfmt * Restyled by autopep8 * removeing quotes from wildcard * more conversions * Updating dry-run golden standard files --------- Co-authored-by: Restyled.io <[email protected]>
…c changes (#36225) * da_revocation: align the revocation set generation algorithm with spec changes * Add types to few methods * address review comments * add the vid/pid checks for PAI delegated crl signer * get_paa_cert_for_crl_issuer is actually fetching the issuer cert rather than the PAA
Two Targets are added: 1- Unit Test Mode: which executes all FuzzTests in a single binary for a few seconds 2- Continous Fuzzing Mode: we choose a specific FuzzTest, it will only stop execution once a crash occurs or user explicitly Interrupts it
…ns (#36470) - w0s and w1s are not exactly identical to w0 and w1
* Incorporate Spec updates to CameraAVStreamMgmt cluster - Use Alchemy to re-generate the xml. - Add feature tag to attributes and commands. - Remove SetViewport and ImageRotation commands. * Autogenerated files after running zap_regen_all.py.
* matter-devices.xml: Fix DEM (Simple -> Utility) This change fixes the DEM device type description in matter-devices.xml. The most relevant change is fixing the class type from Simple to Utility. This was generated using alchemy with the command: ``` alchemy/alchemy zap --attribute="in-progress" --sdkRoot=./connectedhomeip/ --specRoot=./connectedhomeip-spec/ ./connectedhomeip-spec/src/device_types/DeviceEnergyManagement.adoc ``` * zap regen * Fix name to avoid unwanted changes on Zap generation.
… network ID (#36435) Signed-off-by: Martin Girardot <[email protected]>
* chef: Fix FanControl mode/speed interdepency behavior This PR implements the FanControl logic to ensure the interdependent behavior between Mode/Speed/Percent is coherent. This is based on what was done in the AirPurifier examples. Changes: * Removed Custom Write/Read * Updated Zap file `SpeedMax` default to 10 instead of 100 * Forward `MatterPostAttributeChangeCallback` FanControl-related changes to `ChefFanControlManager` * Implements Mode/Speed/Percent interdependency logic based on the AirPurifier example Test: * Verified that Mode, Speed and SpeedPercent change accordingly when any of those attributes change and cross a boundary. * ifdef out code for non-fancontrol examples. * Address Boris' review feedback * Update examples/chef/common/chef-fan-control-manager.cpp Co-authored-by: Andrei Litvin <[email protected]> * Andrei's review suggestions * review suggestions: clarify Auto behavior and use struct for ranges. * Fix minor bug introduced when addressing review suggestions (!= vs ==) * Update examples/chef/common/chef-fan-control-manager.cpp Co-authored-by: Andrei Litvin <[email protected]> * fix const * Apply suggestions from Andrei's code review Co-authored-by: Andrei Litvin <[email protected]> * Restyled by clang-format * Apply Boris' suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Address Boris' review suggestions --------- Co-authored-by: Andrei Litvin <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
This reverts commit 078bc30.
* Generated using ./alchemy zap --attribute="in-progress" ... ZoneManagement.adoc * Generated using ./scripts/tools/zap_regen_all.py * Remove renamed file * Restyled by whitespace * Restyled by prettier-json * Remove renamed file * Remove choice for single element --------- Co-authored-by: Restyled.io <[email protected]>
…(#36348) * Shutdown DefautICDClientStorage when destorying Android controller * Restyled by whitespace * Update DefaultICDClientStorage.h Co-authored-by: Boris Zbarsky <[email protected]> --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
* Add FuzzTests for PASE Message Receiving * Integrating Comments * Removing two unused global string constants * Integrating Comments
* Change output folder for apps * Update integrations/docker/images/chip-cert-bins/Dockerfile * Update integrations/docker/images/chip-cert-bins/Dockerfile
…(#36477) * Restructure platform files * Move all files to src/platform * Build the wf200 in the new wifi structure * rename directory * Build the rs9116 in the new wifi structure * Build the SiWx917 NCP in the new wifi structure * Build the SiWx917 SoC in the new wifi structure * Delete wfx_host_events header in favor of the new abstraction structure * remove unnecessary includes in gn files and the cflag changes * restyle * add todo comment * remove cflag inclusion * add missing incllude * Add missing includes * Restyled by clang-format * Move wifi_args.gni file to the wifi directory * Rename Wf200WifiInterface to WifiInterface * Rename SiWxWifiInterface to WifiInterface * Rename Rsi91xWifiInterface.cpp to WifiInterface.cpp --------- Co-authored-by: Restyled.io <[email protected]>
jmartinez-silabs
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to not squash merge
mykrupp
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR updates the main branch from csa::master. A branch was created because their was a conflict to fix in the sl_wifi_interface file where a fix was upstreamed to csa.
Tests
CI