[Silabs] Adds changes for min and max values of refrigerator temperat…

…ure controlled cabinet (#36592) * Adds changes for min and max values of refrigerator temperature control cabinet * Removed the manual set for temperatureset-point * Converting Fahrenheit to Celsius min max values
SiliconLabsSoftware · Nov 22, 2024 · 6b37cc9 · 6b37cc9
1 parent e66991b
commit 6b37cc9
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 17 deletions.
diff --git a/examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.matter b/examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.matter
@@ -1960,8 +1960,8 @@ endpoint 2 {
 
   server cluster TemperatureControl {
     ram      attribute temperatureSetpoint;
-    ram      attribute minTemperature;
-    ram      attribute maxTemperature;
+    ram      attribute minTemperature default = -18;
+    ram      attribute maxTemperature default = -15;
     ram      attribute step;
     callback attribute generatedCommandList;
     callback attribute acceptedCommandList;
@@ -1990,8 +1990,8 @@ endpoint 3 {
 
   server cluster TemperatureControl {
     ram      attribute temperatureSetpoint;
-    ram      attribute minTemperature;
-    ram      attribute maxTemperature;
+    ram      attribute minTemperature default = 0;
+    ram      attribute maxTemperature default = 4;
     ram      attribute step;
     callback attribute generatedCommandList;
     callback attribute acceptedCommandList;

diff --git a/examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.zap b/examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.zap
@@ -3860,7 +3860,7 @@
               "storageOption": "RAM",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": "-18",
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -3876,7 +3876,7 @@
               "storageOption": "RAM",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": "-15",
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -4207,7 +4207,7 @@
               "storageOption": "RAM",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": "0",
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -4223,7 +4223,7 @@
               "storageOption": "RAM",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": "4",
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,

diff --git a/examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter b/examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter
@@ -1867,8 +1867,8 @@ endpoint 2 {
 
   server cluster TemperatureControl {
     ram      attribute temperatureSetpoint;
-    ram      attribute minTemperature;
-    ram      attribute maxTemperature;
+    ram      attribute minTemperature default = -18;
+    ram      attribute maxTemperature default = -15;
     ram      attribute step;
     callback attribute generatedCommandList;
     callback attribute acceptedCommandList;
@@ -1897,8 +1897,8 @@ endpoint 3 {
 
   server cluster TemperatureControl {
     ram      attribute temperatureSetpoint;
-    ram      attribute minTemperature;
-    ram      attribute maxTemperature;
+    ram      attribute minTemperature default = 0;
+    ram      attribute maxTemperature default = 4;
     ram      attribute step;
     callback attribute generatedCommandList;
     callback attribute acceptedCommandList;

diff --git a/examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.zap b/examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.zap
@@ -3749,7 +3749,7 @@
               "storageOption": "RAM",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": "-18",
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -3765,7 +3765,7 @@
               "storageOption": "RAM",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": "-15",
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -4096,7 +4096,7 @@
               "storageOption": "RAM",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": "0",
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,
@@ -4112,7 +4112,7 @@
               "storageOption": "RAM",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "",
+              "defaultValue": "4",
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,

diff --git a/examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp b/examples/refrigerator-app/silabs/src/RefrigeratorManager.cpp
@@ -102,7 +102,6 @@ void RefrigeratorManager::TempCtrlAttributeChangeHandler(EndpointId endpointId,
     case TempCtrlAttr::TemperatureSetpoint::Id: {
         int16_t temperatureSetpoint = ConvertToPrintableTemp(static_cast<int16_t>(*value));
         mTemperatureSetpoint        = temperatureSetpoint;
-        TempCtrlAttr::TemperatureSetpoint::Set(endpointId, temperatureSetpoint);
     }
     break;
     default: {