Skip to content

Commit

Permalink
Deactivating log that causes stack overflow in series 3
Browse files Browse the repository at this point in the history
  • Loading branch information
lpbeliveau-silabs committed Nov 28, 2024
1 parent 29ada74 commit 01dafea
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/include/platform/CHIPDeviceConfig.h
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@
* Defaults to 30000 (30 seconds).
*/
#ifndef CHIP_DEVICE_CONFIG_BLE_ADVERTISING_INTERVAL_CHANGE_TIME
#define CHIP_DEVICE_CONFIG_BLE_ADVERTISING_INTERVAL_CHANGE_TIME 30000
#define CHIP_DEVICE_CONFIG_BLE_ADVERTISING_INTERVAL_CHANGE_TIME 2000
#endif

/**
Expand Down
6 changes: 4 additions & 2 deletions src/platform/silabs/efr32/BLEManagerImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,8 @@ void BLEManagerImpl::BleAdvTimeoutHandler(void * arg)
{
if (BLEMgrImpl().mFlags.Has(Flags::kFastAdvertisingEnabled))
{
ChipLogDetail(DeviceLayer, "bleAdv Timeout : Start slow advertisement");
// TODO : This log causes a stack overflow in Series 3, need to investigate before re-enabling
// ChipLogDetail(DeviceLayer, "bleAdv Timeout : Start slow advertisement");
BLEMgrImpl().mFlags.Set(Flags::kAdvertising);
BLEMgr().SetAdvertisingMode(BLEAdvertisingMode::kSlowAdvertising);
#if CHIP_DEVICE_CONFIG_EXT_ADVERTISING
Expand All @@ -1016,7 +1017,8 @@ void BLEManagerImpl::BleAdvTimeoutHandler(void * arg)
#if CHIP_DEVICE_CONFIG_EXT_ADVERTISING
else
{
ChipLogDetail(DeviceLayer, "bleAdv Timeout : Start extended advertisement");
// TODO : This log causes a stack overflow in Series 3, need to investigate before re-enabling
// ChipLogDetail(DeviceLayer, "bleAdv Timeout : Start extended advertisement");
BLEMgrImpl().mFlags.Set(Flags::kAdvertising);
BLEMgrImpl().mFlags.Set(Flags::kExtAdvertisingEnabled);
BLEMgr().SetAdvertisingMode(BLEAdvertisingMode::kSlowAdvertising);
Expand Down
4 changes: 2 additions & 2 deletions src/platform/silabs/tracing/SilabsTracing.h
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ class SilabsTracer
{
public:
static constexpr size_t kNumTraces = to_underlying(TimeTraceOperation::kNumTraces);
static constexpr size_t kMaxBufferedTraces = 64;
static constexpr size_t kMaxTraceSize = 256;
static constexpr size_t kMaxBufferedTraces = 32;
static constexpr size_t kMaxTraceSize = 128;

/** @brief Get the singleton instance of SilabsTracer */
static SilabsTracer & Instance() { return sInstance; }
Expand Down

0 comments on commit 01dafea

Please sign in to comment.