Update provision libraries for SiWx917 #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosahay-silabs
requested review from
jepenven-silabs,
jmartinez-silabs,
mkardous-silabs,
selissia,
lpbeliveau-silabs and
rcasallas-silabs
as code owners
jmartinez-silabs
approved these changes
Jan 9, 2025
senthilku
approved these changes
Jan 10, 2025
rosahay-silabs
deleted the
MATTER-4490-bugfix/revert-provision-keystore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem / Feature
Change overview
Revert the logic of storing private key data instead of the whole ASN1 data. This change was breaking backward compatibility.
Testing
Manually tested, further testing will be done on the CICD. This case is missing in CICD as the device is reprovisioned all the time.