fix LYTHIUM surface names and make always detected on road #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix LYTHIUM surface names and make always detected on road
| @@ -29,12 +29,16 @@ private _surfaceTexture = toLowerANSI (surfaceTexture _pos); | |||
| [_surface, 2, _fnc_scriptName] call HATG_fnc_log; | |||
| [_surfaceTexture, 2, _fnc_scriptName] call HATG_fnc_log; | |||
|
|
|||
| private _surfacesNames = ["grass", "forest", "thorn", "field", "hlina", "trava"]; | |||
| private _surfacesNames = ["grass", "forest", "thorn", "field", "hlina", "trava","gbr_es_plevel1","gbr_es_tierra1","gbr_es_tierra2","gbr_es_tierra3","gbr_es_tierra10"]; | |||
There was a problem hiding this comment.
Rather than giving absolute classnames of surface types, could you not just add "plevel", "tierra"?
In the case that only some of the type123 numbers are actually grass, it would still be better to do the above and make the blacklist actually useful
| @@ -29,12 +29,16 @@ private _surfaceTexture = toLowerANSI (surfaceTexture _pos); | |||
| [_surface, 2, _fnc_scriptName] call HATG_fnc_log; | |||
| [_surfaceTexture, 2, _fnc_scriptName] call HATG_fnc_log; | |||
|
|
|||
| private _surfacesNames = ["grass", "forest", "thorn", "field", "hlina", "trava"]; | |||
| private _surfacesNames = ["grass", "forest", "thorn", "field", "hlina", "trava","gbr_es_plevel1","gbr_es_tierra1","gbr_es_tierra2","gbr_es_tierra3","gbr_es_tierra10"]; | |||
| private _surfacesNamesBlackList = ["gbr_es_tierra12"]; | |||
There was a problem hiding this comment.
Why is a blacklist necessary if you are going to only add absolute names?
|
|
||
| if !(hatg_setting_surfaces) exitWith {true}; | ||
| if (hatg_setting_simple) exitWith {true}; | ||
| if ([_unit] call HATG_fnc_isInBuilding) exitWith {true}; | ||
| if ([_unit] call HATG_fnc_isInBuilding) exitWith {true;}; | ||
| if isOnRoad _unit exitWith {false}; |
There was a problem hiding this comment.
isOnRoad is checked in canCreateMirror. That makes this addition obsolete?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix LYTHIUM surface names and make always detected on road
What purpose does this PR serve?
What have you changed (In a short summary).
Details:
Why was this change necessary?
Details:
Does this pull request change core HATG functionality?
If yes, what core functionality does it change and why?
HATG Automated Testing Result:
Does this PR resolve any open issues?
If applicable, fill out below.
This PR closes #ISSUENUMBER
Is any extra work required or advised?
Details: