-
Notifications
You must be signed in to change notification settings - Fork 44.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dx: Clean up PR template #8541
dx: Clean up PR template #8541
Conversation
This PR targets the Automatically setting the base branch to |
✅ Deploy Preview for auto-gpt-docs canceled.
|
IMO Add a test plan requirement |
@ntindle what do you mean exactly? |
As one of the few reviewing PRs right now, it’s hard to know what things interact with and I need to test |
@ntindle I get that, but what does that mean for this PR? What text do you want to have placed where? |
Swap those sections to writing test plans |
In looking back at this, tbh I like how it is |
Reasons I don't like this stuff being in the PR template like it is now:
|
I think a better move would be converting it to a checklist and adding links to the areas you're discussing |
There is stuff in the PR template that is not template stuff. It should either be commented out so that it's only visible to the author/editor, or moved to the contribution guide. Or changed into a checklist so it can be used to communicate useful information about the PR, but the longer the template gets, the smaller the chance people will actually fill it out.