Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add launch.json debugging for vscode #8496

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Oct 29, 2024

Background

There's a clear need to debug the platform and its tools, so I figured I'd share how I do it as there's not a standard or default for contributors.

Changes 🏗️

Adds launch.json for others to build upon

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

Configuration Changes 📝

Note

Only for the new autogpt platform, currently in autogpt_platform/

If you're making configuration or infrastructure changes, please remember to check you've updated the related infrastructure code in the autogpt_platform/infra folder.

Examples of such changes might include:

  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@ntindle ntindle requested a review from a team as a code owner October 29, 2024 18:58
@ntindle ntindle requested review from Torantulino and Bentlybro and removed request for a team October 29, 2024 18:58
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Configuration Consistency
Ensure that the environment configurations for different components (Frontend, Backend, Marketplace) are consistent and use the correct paths.

Commented Code
There are commented out lines in the configuration. Verify if these should be removed or uncommented.

Copy link
Contributor

@aarushik93 aarushik93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a VScode user, but is it essentually this will work for all VScode ppl?

@ntindle
Copy link
Member Author

ntindle commented Oct 30, 2024

Correct! (not inside docker though, not sure how to set that up yet, but open to ideas or links)

image

They will get something like this. If we get docker working in this, we can setup a group for each

@aarushik93 aarushik93 enabled auto-merge (squash) November 8, 2024 20:46
@aarushik93 aarushik93 merged commit 0b5b95e into dev Nov 8, 2024
9 checks passed
@aarushik93 aarushik93 deleted the vs-code-debugger branch November 8, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants