Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show error toast on Run failure when inputs or credentials are i… #8391

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

Abhi1992002
Copy link
Contributor

Fixes #8332

Background

The issue is that when “Run” fails due to invalid inputs (e.g., deleted credentials), no error message is shown in the UI.

Changes 🏗️

  • Added toast notification (variant="destructive") for "Run" failures.
  • Displays error when the execution request returns an HTTP 400 due to invalid hard-coded input values
invalid.inputs.mov

@Abhi1992002 Abhi1992002 requested a review from a team as a code owner October 22, 2024 07:10
@Abhi1992002 Abhi1992002 requested review from Swiftyos and Pwuts and removed request for a team October 22, 2024 07:10
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Oct 22, 2024
Copy link

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

8332 - Fully compliant

Fully compliant requirements:

  • Show error if queueing graph execution fails
  • Display a toast with variant="destructive" containing the error message
  • Show error when execution request returns HTTP 400 due to invalid inputs
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Error Handling
Verify if the error messages in the toasts are sufficiently descriptive and helpful for users to understand and potentially resolve the issues.

Code Duplication
Consider refactoring the repeated toast creation code into a separate function to improve maintainability and reduce duplication.

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for auto-gpt-docs ready!

Name Link
🔨 Latest commit 63c838e
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67174fe7c99d920008e6adbf
😎 Deploy Preview https://deploy-preview-8391--auto-gpt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we revert the change to supabase, this is good to go!

@ntindle ntindle changed the base branch from master to dev October 22, 2024 19:47
Copy link
Member

@ntindle ntindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert supabase change and this is ready after

@Abhi1992002
Copy link
Contributor Author

Done..!!

@ntindle ntindle self-requested a review October 23, 2024 21:19
@aarushik93
Copy link
Contributor

@Abhi1992002 can you fix the tests please and then we can get this in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/m
Projects
Status: 🚧 Needs work
Development

Successfully merging this pull request may close these issues.

Show error if queueing graph execution fails
4 participants